1774589 - [css-values-4] Implement trigonometric functions and constants

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Seokho Song]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/102.0.0.0 Safari/537.36

Expected results:

According to the new CSS specification [1], CSS should support trigonometric functions sin(), cos(), tan(), asin(), acos(), atan(), atan2().

[1] https://www.w3.org/TR/css-values-4/#trig-funcs

Comment 1

[Emilio Cobos Álvarez (:emilio)]

These are implemented already behind layout.css.trig.enabled. When I implemented them, the missing bits were test coverage.

Comment 2

[Sebastian Zartner [:sebo]]

Cool! Sounds like this is basically shippable. Is there already a bug for adding those tests? And should there be a separate one for shipping them or should this bug be used for that?

Sebastian

Comment 4

[Sebastian Zartner [:sebo]]

For reference, the constants that are obviously also already implemented behind the pref mentioned in comment 1 are defined at https://drafts.csswg.org/css-values-4/#calc-constants.

Sebastian

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1774589 - Implement atan2(), and enable calc() trigonometric functions by default on nightly. r=boris

We now have test coverage, so let's do this.

The remaining failures are just about infinity/nan, which is a
completely different feature.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1774589 - Fix a couple css-values tests while at it. r=#style,#layout

While I was looking at this, let's fix some incorrect tests.

The changes to expect simplification come from
https://drafts.csswg.org/css-values-4/#calc-simplification:

Internal representations of math functions are eagerly simplified to
the extent possible, using standard algebraic simplifications
(distributing multiplication over sums, combining similar units,
etc.)

The changes to tests that expected 0% / 0px / etc are just wrong because
the test harness treat 0 as the "default" used value, and fails. These
fail in all browsers.

Depends on D154831

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Let's enable on nightly for now, we can enable everywhere after the soft freeze.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03b2061c924b
Implement atan2(), and enable calc() trigonometric functions by default on nightly. r=boris
https://hg.mozilla.org/integration/autoland/rev/bcf5fcb47b4a
Fix a couple css-values tests while at it. r=boris

Comment 9

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d850765046a
Annotate a test that's failing on macOS.

Comment 11

[Marian-Vasile Laza]

Backed out 5 changesets (Bug 1682444, Bug 1774589) for causing wpt failures on acos-asin-atan-atan2-serialize.html.
Backout link
Push with failures --> 1st push <--> push with fix
Failure Log wpt6 1st push <--> wpt6 push with fix

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02eccb000404
Implement atan2(), and enable calc() trigonometric functions by default on nightly. r=boris
https://hg.mozilla.org/integration/autoland/rev/fc449cf7d476
Fix a couple css-values tests while at it. r=boris

Comment 13

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/02eccb000404
https://hg.mozilla.org/mozilla-central/rev/fc449cf7d476

Comment 14

[Brian Thomas Smith [bsmth]]

I'm tracking documentation tasks for these changes in the following parent ticket on GitHub: https://github.com/mdn/content/issues/19832

Comment 15

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/36038 for changes under testing/web-platform/tests

Comment 16

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot