1774600 - Tabs are not restored for sources notified late to the frontend

Status: NEW

(DevTools :: Debugger, defect, P3)

Description

[Alexandre Poirot [:ochameau]]

This is especially visible in the Browser Toolbox as we retrieve sources from many targets.

This issue comes from this code:
https://searchfox.org/mozilla-central/rev/ec3889f74d6b5695833280f4370ca0e9ba59a3e4/devtools/client/debugger/src/reducers/tabs.js#89-106
which will remove all previous tabs that are not maching a source.
This function is called any time a new source is added.
So typically on reload, or when reopening the browser toolbox, we will receive a first bucket of sources. ResourceCommand throttling actually helps here by grouping most of the sources in a unique bucket.
But then, any source notified after won't have their tab restored. That, unless if the source was the selected one.

I identified this while doing some cleanups in bug 1774583.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1774600 - [devtools] Sources injected late should have their tab re-opened. r=bomsy

For now, we were reopening tabs only for sources available in the first bucket of sources.
Thanks to ResourceCommand throttling, most sources are available in one chunk after reload.
But if any comes late, their previously opened tab will be discarded.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/23679cf5a9d7
[devtools] Sources injected late should have their tab re-opened. r=bomsy,devtools-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df44ad7320d0
Revert "Bug 1774600 - [devtools] Sources injected late should have their tab re-opened. r=bomsy,devtools-reviewers" for causing dt failures at browser_dbg-tabs.js

Comment 4

[Cristina Horotan [:chorotan]]

Backed out for causing dt failures

Backout link

Push with failures

Failure log