1774690 - [wpt-sync] Sync PR 34475 - [TableFragmentation] Nested repeated table headers

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 34475 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/34475
Details from upstream follow.

Alison Maher <[e-mail]> wrote:

[TableFragmentation] Nested repeated table headers

If a table header was nested inside of another, we would end up
breaking forever. This happened because we would set if the header
ConstraintSpace IsRepeated() based on its parent's ConstraintSpace.
Because the parent's ConstraintSpace had IsRepeated() set to true in
this case, the inner header would never terminate repeating itself,
even when RelayoutAsLastTableBox() was called.

To fix this, don't rely on the parent ConstraintSpace to set this.
Also consider what repeat_mode is set to for the current header.

Once this was fixed, we also ran into an issue when cloning these
nested headers (because they were already repeated). To get this
working, NGFragmentRepeater::GetClonableLayoutResult() needed to be
updated to consider if the repeated break token was the result of
a different fragmentation context than the current header being
cloned.

Bug: 1336683
Change-Id: I13e7af8ce91144e4c3c22eca6dc2a45a0f1a9b80
Reviewed-on: https://chromium-review.googlesource.com/3710528
WPT-Export-Revision: 03d9c31cd60edbc3db9d0b838b135658cce9d5ca

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=0fb8ec879ba65271a209edd28d081930e0981847

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59ba166df6de
[wpt PR 34475] - [TableFragmentation] Nested repeated table headers, a=testonly

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/59ba166df6de