1774802 - TB 102b6: OpenPGP Key assistant misses error message / info when using openPGP aliases

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect, P1)

Description

[Chaos Prevails]

Attachment: tb91_gpgalias.jpg (1).png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:101.0) Gecko/20100101 Firefox/101.0

Steps to reproduce:

1. create alias file, and configure TB for it
2. try to send an encrypted email via an alias, but one referred key is missing
3. click send button

Actual results:

1. after clicking send, I see the OpenPGP Key Assistant, however, there is no information about what is wrong (I can only click "disable encryption")
2. in previous TB versions (e.g. TB91), I could see "mapped to XX alias keys" , or "unusable/unavailable alias key" if there was a problem.

Expected results:

1. show similar information also in TB 102 (e.g. at least give information which alias is causing a problem, as was the case in TB91, ideally provide the same information TB91 has provided (e.g. "mapped to XX alias keys")

Comment 1

[Magnus Melin [:mkmelin]]

https://searchfox.org/comm-central/rev/7db3fb60ede28ef82c543940f39e67d7ff0ea7b9/mail/extensions/openpgp/content/ui/keyAssistant.js#196

Comment 2

[Kai Engert [:KaiE:]]

Yes this is confusing, thanks for reporting. Luckily it's just cosmetic and only affects users of this advanced configuration. But I agree we should fix it quickly.

Comment 3

[Kai Engert [:KaiE:]]

Attachment: Bug 1774802 - OpenPGP key assistant should show status for email addresses covered by Aliases. r=mkmelin

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4394b0f738a3
OpenPGP key assistant should show status for email addresses covered by Aliases. r=mkmelin

Comment 5

[Kai Engert [:KaiE:]]

Comment on attachment 9282133 [details]
Bug 1774802 - OpenPGP key assistant should show status for email addresses covered by Aliases. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): 1764324
User impact if declined: wrong UI for users of OpenPGP aliases
Testing completed (on c-c, etc.): manually & automated test
Risk to taking this patch (and alternatives if risky): low. limited to OpenPGP key assistant. moved code makes the patch look bigger than it is.

Comment 6

[Kai Engert [:KaiE:]]

While the key assistant is new in 102, this could still be considered a regression - because the UI replaced by the key assistant did show information about the alias.

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9282133 [details]
Bug 1774802 - OpenPGP key assistant should show status for email addresses covered by Aliases. r=mkmelin

[Triage Comment]
Approved for esr102

Thomas will you be able to test this?

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 102.0.1:
https://hg.mozilla.org/releases/comm-esr102/rev/734e38c3e900

Comment 9

[Thomas D. (:thomas8)]

(In reply to Wayne Mery (:wsmwk) from comment #7)

Thomas will you be able to test this?

Not without additional input from Kai.
As Kai said in comment 2, this involves "advanced configuration" of OpenPGP. I'm a bloody beginner in OpenPGP, and I don't know about the alias used here.

Comment 10

[Chaos Prevails]

Hello Thomas,

if this helps, I can provide a dummy TB profile with openPGP alias configured, and a couple of keys.