1774888 - Remove XPCOMUtils.defineLazyModuleGetter

Status: RESOLVED FIXED

(Core :: XPConnect, task)

Description

[Tooru Fujisawa [:arai]]

https://searchfox.org/mozilla-central/rev/49566d906ad040cf233b0a5acd597e1a63b92f72/js/xpconnect/loader/XPCOMUtils.jsm#192-220

/**
 * Defines a getter on a specified object for a module.  The module will not
 * be imported until first use. The getter allows to execute setup and
 * teardown code (e.g.  to register/unregister to services) and accepts
 * a proxy object which acts on behalf of the module until it is imported.
 *
 * @param aObject
 *        The object to define the lazy getter on.
 * @param aName
 *        The name of the getter to define on aObject for the module.
 * @param aResource
 *        The URL used to obtain the module.
 * @param aSymbol
 *        The name of the symbol exported by the module.
 *        This parameter is optional and defaults to aName.
 * @param aPreLambda
 *        A function that is executed when the proxy is set up.
 *        This will only ever be called once.
 * @param aPostLambda
 *        A function that is executed when the module has been imported to
 *        run optional teardown procedures on the proxy object.
 *        This will only ever be called once.
 * @param aProxy
 *        An object which acts on behalf of the module to be imported until
 *        the module has been imported.
 */
defineLazyModuleGetter: function XPCU_defineLazyModuleGetter(
                                 aObject, aName, aResource, aSymbol,
                                 aPreLambda, aPostLambda, aProxy)

4th parameter to define an alias is going to be handled in bug 1772969, and there's no in-tree consumer for 5th+ parameters.

Comment 1

[Tooru Fujisawa [:arai]]

This should be done only after the out-of-tree migration finishes, to avoid unnecessary compat issue.

Comment 2

[Mark Banner (:standard8)]

Once we've finished updating the privileged add-ons, we should be able to completely remove this function.

Comment 3

[Mark Banner (:standard8)]

I think this is long enough obsolete and not used that we could fully remove support for it now. The rule was originally added in Firefox 57 (bug 1431533).

Comment 4

[Mark Banner (:standard8)]

Attachment: Bug 1774888 - Remove XPCOMUtils.defineLazyModuleGetter. r?arai!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd5f6bc69743
Remove XPCOMUtils.defineLazyModuleGetter. r=arai

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/cd5f6bc69743