1775017 - [x11] XULPopupElement::GetOuterScreenRect is incorrect on HiDPI screens.

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

This is due to a GTK bug, see https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/4820, but prevents tests from working locally.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1775017 - Don't use gdk_window_get_root_origin on popups, as those get the wrong coordinates on X11+HiDPI. r=stransky

See the linked GTK MR (which also affects GTK3). This can be reproduced
when running tests like
browser/components/extensions/test/browser/browser_ext_popup_select_in_oopif.js

In an X11 session with a HiDPI screen.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bee17c93a75a
Don't use gdk_window_get_root_origin on popups, as those get the wrong coordinates on X11+HiDPI. r=stransky

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/bee17c93a75a

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Looks like it's already fixed in Gtk3 - https://gitlab.gnome.org/GNOME/gtk/-/commit/c43e3c43396abcdbd6b0f6e2565f8563b52c5027

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Fixed in Gtk3-3.24.35.

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Unfortunately Ubuntu 22.04 has Gtk3 3.24.33 only.

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Looks like this one affects X11/GDK_WINDOW_TEMP windows only which uses override redirect. We may try to not use GDK_WINDOW_TEMP on X11 platform for popups.