1775150 - Cleanup js/xpconnect includes

Status: RESOLVED FIXED

(Core :: XPConnect, enhancement)

Description

[serge-sans-paille]

Steps to reproduce:

Run include-what-you use on js/xpconnect directory

Actual results:

Unused headers got reported

Expected results:

Less headers should be reported

Comment 1

[serge-sans-paille]

Attachment: Bug 1775150 - Cleanup js/xpconnect includes

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::XPConnect' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/004885c1597c
Cleanup js/xpconnect includes r=sylvestre

Comment 4

[Natalia Csoregi [:nataliaCs]]

Backed out for causing bustage on mozJSModuleLoader.h

• backout: https://hg.mozilla.org/integration/autoland/rev/138d01371f94d774ad053253aad128fcc39b3c99
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=004885c1597c0f8827a94ec7af0e216c668563e0
• failure log: https://treeherder.mozilla.org/logviewer?job_id=382529519&repo=autoland&lineNumber=9755

[task 2022-06-25T13:56:01.246Z] 13:56:01     INFO -  In file included from /builds/worker/checkouts/gecko/dom/base/ChromeUtils.cpp:55:
[task 2022-06-25T13:56:01.246Z] 13:56:01     INFO -  /builds/worker/checkouts/gecko/js/xpconnect/loader/mozJSModuleLoader.h:23:10: fatal error: 'xpcIJSGetFactory.h' file not found
[task 2022-06-25T13:56:01.247Z] 13:56:01     INFO -  #include "xpcIJSGetFactory.h"
[task 2022-06-25T13:56:01.247Z] 13:56:01     INFO -           ^~~~~~~~~~~~~~~~~~~~
[task 2022-06-25T13:56:01.247Z] 13:56:01     INFO -  1 error generated.
[task 2022-06-25T13:56:01.248Z] 13:56:01    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:668: Unified_cpp_dom_base1.o] Error 1
[task 2022-06-25T13:56:01.248Z] 13:56:01     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/dom/base'
[task 2022-06-25T13:56:01.248Z] 13:56:01     INFO -  gmake[4]: *** Waiting for unfinished jobs....

Comment 5

[serge-sans-paille]

Sorry for the inconvenience. I'm rebasing the patch and adjust.

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/8b568707f7ae