1775203 - Reduce number of state updates related to symbols

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement)

Description

[Alexandre Poirot [:ochameau]]

For now there is three possible states for symbols of a given source:

• null
• { loading: true }
• { ... populate symbols object ... }

Given that we force fetching the symbols when selecting a source:
https://searchfox.org/mozilla-central/rev/b1a5802e0f73bfd6d2096e5fefc2b47831a50b2d/devtools/client/debugger/src/actions/sources/select.js#191
I think that the intermediate { loading: true } isn't necessary. Instead we could consider that symbols are loading if symbols are null.
This would reducer the number of state changes, reduce the number of calls to mapStateToProps and also avoid unecessary re-rendering of components tied to symbols.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1775203 - [devtools] Remove "loading" state of symbols state object.

This helps reduce the number of state changes and the number of renders.
We now switch from null symbols which means they are loading,
to an object with the loaded symbols.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1775203 - [devtools] Unify code around getSymbols method.

Now that we no longer have the intermediate "loading" object,
we can simplify the code checking for loading symbols by checking
if symbols are defined.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1574d614ce48
[devtools] Remove "loading" state of symbols state object. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/485c98c274d3
[devtools] Unify code around getSymbols method. r=bomsy,perftest-reviewers,davehunt

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/1574d614ce48
https://hg.mozilla.org/mozilla-central/rev/485c98c274d3