1775244 - HTTP2ProxyCode does not work as a http2 proxy

Status: RESOLVED FIXED

(Core :: Networking: HTTP, task, P2)

Description

[Kershaw Chang [:kershaw]]

See here.
HTTP2ProxyCode actually works as a http1 proxy, not http2.

Comment 1

[Kershaw Chang [:kershaw]]

Attachment: Bug 1775244 - Make HTTP2ProxyCode speak Http/2, r=#necko

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d82f37e0c57
Make HTTP2ProxyCode speak Http/2, r=necko-reviewers,dragana

Comment 3

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing Xpcshell failures on test_servers.js
Backout link
Push with failures
Link to failure log
Failure line :
TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_servers.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_servers.js | test_http2_proxy - [test_http2_proxy : 274] "h2" == "http/1.1"

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:kershaw, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 5

[Dragana Damjanovic [:dragana]]

Kershaw will lend this when appropriate.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last months and this bug has priority 'P2'.
:dragana, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Redirect a needinfo that is pending on an inactive user to the triage owner.
:dragana, since the bug has high priority and recent activity, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4884f2748ee6
Make HTTP2ProxyCode speak Http/2, r=necko-reviewers,dragana

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/4884f2748ee6

Comment 10

[Geoff Lankow (:darktrojan)]

Kershaw, test_servers.js is failing on Windows on comm-central after this change (example log). Any ideas why?

Comment 11

[Kershaw Chang [:kershaw]]

(In reply to Geoff Lankow (:darktrojan) from comment #10)

Kershaw, test_servers.js is failing on Windows on comm-central after this change (example log). Any ideas why?

Could you help me to verify if this patch fixes the test failure on comm-central?
Thanks.

Comment 12

[Geoff Lankow (:darktrojan)]

Looks good to me! Thanks.
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=9053d6b0f48a973e41e44c938e88b2dd3dfd37e8&group_state=expanded