1775451 - Problem with navigation with keyboard use - Accesibility

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[marek.zdybel]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:101.0) Gecko/20100101 Firefox/101.0

Steps to reproduce:

Here is reproduced bug from production:
https://jsfiddle.net/mzdybel/sya5tzfv/95/
Only under Firefox bug is executed.
Try to navigate with keyboard.
After focus with tab key "skip-panel: language" element user are moved to the top of page...

Actual results:

The skip-link element which switched position:absolute to position:static on focus, when user presses TAB key is correctly focused, correctly positioned and visible, but the page jumped to the previous position of that element, not to the current position. As if focus occurs before styles are applied. Surely that is the case in reality, but other browsers do apply styles before and page jump don't happen.

Comment 1

[Peter Magyari (Desktop QA)]

This is also reproducible also on MacOS.
I'm setting a component in order to get the development involved in reviewing this issue.
Feel free to re-set the component if this does not seem the most suitable one.

Thank you for reporting!

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Test-case from reporter

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Reduced test-case.

What's the use-case to move the .sr-only content to the top and only putting it on its static position on focus?

The issue is that we scroll-into-view right before changing the focus state, while other browsers do it right after.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1775451 - Scroll into view after changing focus state, not before. r=smaug

This matches other browsers.

The scroll event is dispatched async, so
the test would mostly pass without the patch, actually, except for the
fact that we wouldn't scroll. So without the patch the test times out.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a4ba27058a9
Scroll into view after changing focus state, not before. r=smaug

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/34601 for changes under testing/web-platform/tests

Comment 7

[Cristian Tuns]

Backed out for causing mochitest failures on test_imestate.html

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | widget/tests/test_imestate.html | assertion count 1 is more than expected 0 assertions

Another log Fail 2: https://treeherder.mozilla.org/logviewer?job_id=382611529&repo=autoland
Failure line 2: TEST-UNEXPECTED-FAIL | dom/tests/mochitest/general/test_focus_scrollchildframe.html | Scrolled child frame into view

Log 3: https://treeherder.mozilla.org/logviewer?job_id=382612649&repo=autoland
Line 3: TEST-UNEXPECTED-FAIL | layout/forms/test/test_bug446663.html | assertion count 2 is more than expected 0 assertions

Comment 8

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84e1b52befea
Scroll into view after changing focus state, not before. r=smaug

Comment 10

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/84e1b52befea

Comment 11

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot