1775477 - Should keygen be an HTMLElement or an HTMLUnknownElement?

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

Right now it's the former, but if we regenerate ElementName.java we get the later. I manually changed it back in bug 1372276 but we should figure out what's the right thing to do and either fix nsHTMLTags.h or the parser.

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

document.createElement("keygen").constructor.name is already HTMLUnknownElement while document.createRange().createContextualFragment("<keygen>").children[0].constructor.name is HTMLElement.

Other elements in https://html.spec.whatwg.org/multipage/obsolete.html#non-conforming-features gives HTMLUnknownElement for both, so I believe unknown is the right way.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Yes, I agree.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1775477 - Fix interface for parser-created <keygen> elements. r=hsivonen,saschanaz

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: GitHub Pull Request for parser changes.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1865e24c6775
Fix interface for parser-created <keygen> elements. r=saschanaz

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/34547 for changes under testing/web-platform/tests

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/1865e24c6775

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot