1775522 - Add timestamps to updater logs

Status: RESOLVED FIXED

(Toolkit :: Application Update, task, P3)

Description

[Robin Steuber (they/them) [:bytesized]]

It would be helpful if the updater logs contained timestamps. It seems like a pretty low effort thing to add that would occasionally make it easier to find problems.

For example, I've had times where it wasn't clear if updates were being attempted at all, so it would be nice to know if the logs were recent. I've also had to investigate slow updates, and timestamps would help narrow down what is causing the updates to take so long.

Comment 1

[Max]

Attachment: Bug 1775522 - Add timestamps to updater logs, r?bytesized

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/38bea6dcef39
Add timestamps to updater logs, r=bytesized,application-update-reviewers

Comment 3

[Sandor Molnar[:smolnar]]

Backed out changeset 38bea6dcef39 (bug 1775522) for causing xpc failures in toolkit/mozapps/update/tests/unit_base_updater/marSuccessComplete.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/36d927c5e6bf8061356dc3698b64fe4a90cfedcf

Push with failures

Failure log

Comment 4

[Max]

I was able to reproduce the problem locally and identify its cause. The test worked well as it has identified a change in the log file format. I have now adapted the test to support timestamps in log files and I am currently conducting further tests on top of that change. Thanks for your intervention.

Comment 5

[Max]

Attachment: Bug 1775522 - Add timestamps to updater logs, r=bytesized

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/715213e00a5b
Add timestamps to updater logs with test adaption, r=bytesized,application-update-reviewers

Comment 7

[Marian-Vasile Laza]

Backed out changeset 715213e00a5b (Bug 1775522) for causing xpcshell failures on marStageSuccessCompleteSvc.js.
Backout link
Push with failures <--> X1
Failure Log

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0814312de5e4
Add timestamps to updater logs with test adaption, r=bytesized,application-update-reviewers

Comment 9

[Marian-Vasile Laza]

Backed out changeset 0814312de5e4 (Bug 1775522) for causing xpcshell failures on marSuccessCompleteSvc.js.
Backout link
Push with failures <--> X1
Failure Log

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/da41bde3e3b0
Add timestamps to updater logs with test adaption, r=bytesized,application-update-reviewers

Comment 11

[Sandor Molnar[:smolnar]]

Backed out for causing xpc failures in toolkit/mozapps/update/tests/unit_service_updater/marStageSuccessCompleteSvc.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/12300304d39453250dfdaa8e249056659a20adbc

Push with failures

Failure log

TEST-UNEXPECTED-FAIL | toolkit/mozapps/update/tests/unit_service_updater/marStageSuccessCompleteSvc.js | checkUpdateLogContents - [checkUpdateLogContents : 3554] the update log contents should equal the expected value - "Begin moving destDir (C:/Program Files (x86)/Mozilla Maintenance Service/marStageSuccessCompleteSvc/dir.app) to tmpDir (C:/Program Files (x86)/Mozilla Maintenance Service/marStageSuccessCompleteSvc/dir.app.bak)" ==  "rename_file: proceeding to rename the directory"

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/519304e18e63
Add timestamps to updater logs, r=bytesized,application-update-reviewers

Comment 13

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/519304e18e63