Open Bug 1775605 Opened 3 years ago Updated 5 days ago

Intermittent browser/components/sessionstore/test/browser_label_and_icon.js | single tracking bug

Categories

(Firefox :: Session Restore, defect, P3)

defect

Tracking

()

People

(Reporter: jmaher, Assigned: sfoster)

References

Details

(Keywords: intermittent-failure, intermittent-testcase, leave-open, Whiteboard: [stockwell disabled])

Attachments

(3 files)

No description provided.

Additional information about this bug failures and frequency patterns can be found by running: ./mach test-info failure-report --bug 1775605

Update:
There have been 25 failures within the last 7 days:
• 2 failures on Windows 11 x86 22H2 WebRender opt
• 4 failures on Windows 11 x86 22H2 WebRender Shippable opt
• 4 failures on Windows 11 x64 22H2 WebRender opt
• 15 failures on Windows 11 x64 22H2 WebRender Shippable opt
All the failures classified here are with this failure line: TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_label_and_icon.js | label is set - Got "about:robots", expected "Gort! Klaatu barada nikto!"
Recent failure log: https://treeherder.mozilla.org/logviewer?job_id=425750304&repo=mozilla-central&lineNumber=9415

[task 2023-08-12T00:42:15.685Z] 00:42:15     INFO - TEST-START | browser/components/sessionstore/test/browser_label_and_icon.js
[task 2023-08-12T00:42:15.736Z] 00:42:15     INFO - TEST-INFO | started process screenshot
[task 2023-08-12T00:42:15.846Z] 00:42:15     INFO - TEST-INFO | screenshot: exit 0
[task 2023-08-12T00:42:15.857Z] 00:42:15     INFO - Buffered messages logged at 00:42:15
[task 2023-08-12T00:42:15.858Z] 00:42:15     INFO - Entering test bound test_label_and_icon
[task 2023-08-12T00:42:15.858Z] 00:42:15     INFO - TEST-PASS | browser/components/sessionstore/test/browser_label_and_icon.js | icon is set - 
[task 2023-08-12T00:42:15.859Z] 00:42:15     INFO - Buffered messages finished
[task 2023-08-12T00:42:15.860Z] 00:42:15     INFO - TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_label_and_icon.js | label is set - Got "about:robots", expected "Gort! Klaatu barada nikto!"
[task 2023-08-12T00:42:15.860Z] 00:42:15     INFO - Stack trace:
[task 2023-08-12T00:42:15.860Z] 00:42:15     INFO - chrome://mochikit/content/browser-test.js:test_is:1608
[task 2023-08-12T00:42:15.860Z] 00:42:15     INFO - chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_label_and_icon.js:test_label_and_icon:49
[task 2023-08-12T00:42:15.860Z] 00:42:15     INFO - chrome://mochikit/content/browser-test.js:handleTask:1131
[task 2023-08-12T00:42:15.860Z] 00:42:15     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1203
[task 2023-08-12T00:42:15.860Z] 00:42:15     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1345
[task 2023-08-12T00:42:15.860Z] 00:42:15     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1120
[task 2023-08-12T00:42:15.860Z] 00:42:15     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1056
[task 2023-08-12T00:42:15.860Z] 00:42:15     INFO - Leaving test bound test_label_and_icon
[task 2023-08-12T00:42:16.082Z] 00:42:16     INFO - GECKO(4912) | MEMORY STAT | vsize 1188MB | vsizeMaxContiguous 1293MB | residentFast 398MB | heapAllocated 171MB
[task 2023-08-12T00:42:16.088Z] 00:42:16     INFO - TEST-OK | browser/components/sessionstore/test/browser_label_and_icon.js | took 403ms
[task 2023-08-12T00:42:16.099Z] 00:42:16     INFO - checking window state
[task 2023-08-12T00:42:16.109Z] 00:42:16     INFO - TEST-START | browser/components/sessionstore/test/browser_movePendingTabToNewWindow.js
Whiteboard: [stockwell needswork:owner]

There have been 32 total failures in the last 7 days.
There are:

  • 20 failures on Windows 11 x64 22H2 WebRender Shippable opt
  • 9 failures on Windows 11 x64 22H2 WebRender opt
  • 3 failures on Windows 11 x86 22H2 WebRender Shippable opt

Recent failure log.

[task 2023-10-01T22:13:25.926Z] 22:13:25     INFO - TEST-PASS | browser/components/sessionstore/test/browser_label_and_icon.js | icon is set - 
[task 2023-10-01T22:13:25.927Z] 22:13:25     INFO - Buffered messages finished
[task 2023-10-01T22:13:25.928Z] 22:13:25     INFO - TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_label_and_icon.js | label is set - Got "about:robots", expected "Gort! Klaatu barada nikto!"
[task 2023-10-01T22:13:25.928Z] 22:13:25     INFO - Stack trace:
[task 2023-10-01T22:13:25.928Z] 22:13:25     INFO - chrome://mochikit/content/browser-test.js:test_is:1608
[task 2023-10-01T22:13:25.928Z] 22:13:25     INFO - chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_label_and_icon.js:test_label_and_icon:49
[task 2023-10-01T22:13:25.928Z] 22:13:25     INFO - chrome://mochikit/content/browser-test.js:handleTask:1131
[task 2023-10-01T22:13:25.928Z] 22:13:25     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1203
[task 2023-10-01T22:13:25.928Z] 22:13:25     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1345
[task 2023-10-01T22:13:25.928Z] 22:13:25     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1120
[task 2023-10-01T22:13:25.928Z] 22:13:25     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2023-10-01T22:13:25.928Z] 22:13:25     INFO - Leaving test bound test_label_and_icon
[task 2023-10-01T22:13:26.205Z] 22:13:26     INFO - GECKO(7868) | MEMORY STAT | vsize 2129142MB | vsizeMaxContiguous 66042673MB | residentFast 508MB | heapAllocated 222MB
[task 2023-10-01T22:13:26.214Z] 22:13:26     INFO - TEST-OK | browser/components/sessionstore/test/browser_label_and_icon.js | took 425ms

Dao, any chance you could help us assign this to someone?

Thank you!

Flags: needinfo?(dao+bmo)

Update

There have been 44 total failures within the last 7 days:

  • 3 failures on Windows 11 x86 22H2 WebRender opt
  • 4 failures on Windows 11 x86 22H2 WebRender Shippable opt
  • 10 failures on Windows 11 x64 22H2 WebRender opt
  • 27 failures on Windows 11 x64 22H2 WebRender Shippable opt

Recent log: https://treeherder.mozilla.org/logviewer?job_id=434680745&repo=mozilla-central&lineNumber=8790

[task 2023-11-02T12:28:09.049Z] 12:28:09     INFO - TEST-PASS | browser/components/sessionstore/test/browser_label_and_icon.js | icon is set - 
[task 2023-11-02T12:28:09.050Z] 12:28:09     INFO - Buffered messages finished
[task 2023-11-02T12:28:09.051Z] 12:28:09     INFO - TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_label_and_icon.js | label is set - Got "about:robots", expected "Gort! Klaatu barada nikto!"
[task 2023-11-02T12:28:09.051Z] 12:28:09     INFO - Stack trace:
[task 2023-11-02T12:28:09.051Z] 12:28:09     INFO - chrome://mochikit/content/browser-test.js:test_is:1611
[task 2023-11-02T12:28:09.051Z] 12:28:09     INFO - chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_label_and_icon.js:test_label_and_icon:49
[task 2023-11-02T12:28:09.051Z] 12:28:09     INFO - chrome://mochikit/content/browser-test.js:handleTask:1134
[task 2023-11-02T12:28:09.051Z] 12:28:09     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1206
[task 2023-11-02T12:28:09.051Z] 12:28:09     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1348
[task 2023-11-02T12:28:09.051Z] 12:28:09     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1123
[task 2023-11-02T12:28:09.051Z] 12:28:09     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2023-11-02T12:28:09.052Z] 12:28:09     INFO - Leaving test bound test_label_and_icon
[task 2023-11-02T12:28:09.327Z] 12:28:09     INFO - GECKO(9304) | MEMORY STAT | vsize 2129172MB | vsizeMaxContiguous 67793792MB | residentFast 513MB | heapAllocated 232MB
[task 2023-11-02T12:28:09.327Z] 12:28:09     INFO - TEST-OK | browser/components/sessionstore/test/browser_label_and_icon.js | took 415ms
Assignee: nobody → imoraru
Status: NEW → ASSIGNED

Made a patch to disable this on win 11 opt. If the patch lands, please remember to re-enable the test when making a fix for this.
Thank you!

Assignee: imoraru → nobody
Status: ASSIGNED → NEW
Keywords: leave-open
Pushed by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1a1dc06083d7 disable browser_label_and_icon.js on win 11 opt for frequent failures. r=sclements,sessionstore-reviewers DONTBUILD
Whiteboard: [stockwell disable-recommended] → [stockwell disabled]
See Also: → 1917223

I saw this test failing in one of my pushes to try and so I took a look to confirm that wasn't triggered by the changes in my push to try and I noticed something that may be useful detail to consider while investigating this again:

when the test fails due to the tab.label being set to the tab url about:robots instead of the expected webpage title, the state we retrieved from the call to ss.getTabState(tab); also has "about:robots" as the title set in the tab state (while tab.label was actually set to the expected about:robos document title) and so the tab was restored as expected based on the tab state we got.

I haven't looked further and so I'm not 100% sure, but that seems to suggest that to determine the actual reason for the intermittency it may be worth looking if it may be due to something that is actually happening on the child process side of the SessionStore FlushSessionStore ipc call.

Sam, does Luca's observation help to investigate this frequent failure?

Flags: needinfo?(sfoster)

(In reply to Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout) from comment #127)

Sam, does Luca's observation help to investigate this frequent failure?

It looks like it will do yeah. I'll assign myself, but if you want to disable this in the short term you should go ahead - I'm unlikely to get to it before 135 goes out the door.

Assignee: nobody → sfoster
Flags: needinfo?(sfoster)
Flags: needinfo?(dao+bmo)
Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/autoland/rev/0120cba3f5b5 disable browser/components/sessionstore/test/browser_label_and_icon.js on both Linux and Windows opt for frequent failures. r=jmaher
Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/autoland/rev/ded2e9acc1bb disable browser_label_and_icon.js on Linux ASan for frequent failures
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: