1775797 - Resize directions are not correct when in a rotated container

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P1)

Description

[Calixte Denizet (:calixte)]

Attachment: foo.html

STR:

• open the attachment
• try to resize the green div

It's very hard to resize the div correctly.

In pdf.js, a page can be rotated and we want to be able to resize some editable elements in it.
For information, it works as expected in Chrome.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

That's because the resizer basically only checks for physical positions: https://searchfox.org/mozilla-central/rev/c30349265c87047a324a471d2f39a216b6749262/dom/xul/XULResizerElement.cpp#145,174-176

This is the relevant chromium source that makes this work: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc;l=2171;drc=70b0ee470bd53a63da6c4194579e8c2865db2b79

Should be rather straight-forward to convert the point relative to the current frame before computing the delta.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1775797 - Make resizers use frame-relative coordinates. r=#layout

Comment 3

[Emilio Cobos Álvarez [:emilio]]

The patch I sent fixes it but I can't find a good test to extend. Happy to look into it, but if it's relatively urgent (or you feel like it), writing a WPT for this would be amazing. Calixte, how urgent is this for pdf.js?

Comment 4

[Calixte Denizet (:calixte)]

We want to ship the editing feature in 104 so I'd say it's a bit urgent.
I can disable the container resizing when the rotation angle is not 0 but clearly it'd be better to have this bug fixed asap.

Comment 5

[Hsin-Yi Tsai (she/her) | away [:hsinyi]]

(In reply to Calixte Denizet (:calixte) from comment #4)

We want to ship the editing feature in 104 so I'd say it's a bit urgent.
I can disable the container resizing when the rotation angle is not 0 but clearly it'd be better to have this bug fixed asap.

Setting severity/priority S3/P1 per this comment.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5401aa8df481
Make resizers use frame-relative coordinates. r=TYLin

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/34620 for changes under testing/web-platform/tests

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b16e28a2aab2
Resizers don't work on Android. CLOSED TREE

Comment 9

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/5401aa8df481
https://hg.mozilla.org/mozilla-central/rev/b16e28a2aab2

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 11

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox103 to wontfix.

For more information, please visit auto_nag documentation.