1776135 - Perma browser/components/extensions/test/xpcshell/test_ext_settings_overrides_defaults.js | single tracking bug | xpcshell return code: 0

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: smolnar [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=382239107&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/DWV7elRNQmGXrRyPYiYzFw/runs/0/artifacts/public/logs/live_backing.log

---

 INFO -  TEST-START | xpcshell.ini:browser/components/extensions/test/xpcshell/test_ext_settings_overrides_defaults.js
[task 2022-06-23T05:45:50.200Z] 05:45:50  WARNING -  TEST-UNEXPECTED-FAIL | xpcshell.ini:browser/components/extensions/test/xpcshell/test_ext_settings_overrides_defaults.js | xpcshell return code: 0
[task 2022-06-23T05:45:50.200Z] 05:45:50     INFO -  TEST-INFO took 993ms
[task 2022-06-23T05:45:50.200Z] 05:45:50     INFO -  >>>>>>>
[task 2022-06-23T05:45:50.201Z] 05:45:50     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2022-06-23T05:45:50.202Z] 05:45:50     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2022-06-23T05:45:50.202Z] 05:45:50     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2022-06-23T05:45:50.202Z] 05:45:50     INFO -  running event loop
[task 2022-06-23T05:45:50.204Z] 05:45:50     INFO -  xpcshell.ini:browser/components/extensions/test/xpcshell/test_ext_settings_overrides_defaults.js | Starting setup
[task 2022-06-23T05:45:50.204Z] 05:45:50     INFO -  (xpcshell/head.js) | test setup pending (2)
[task 2022-06-23T05:45:50.204Z] 05:45:50     INFO -  "CONSOLE_MESSAGE: (info) 1655963149658	addons.manager	DEBUG	Application has been upgraded"
<...>
INFO -  PID 3776 | console.debug: SearchService: "#loadEnginesFromSettings: skipped" 5 "built-in engines."
[task 2022-06-23T05:45:50.259Z] 05:45:50     INFO -  PID 3776 | console.debug: SearchService: "#loadEngines: done"
[task 2022-06-23T05:45:50.260Z] 05:45:50     INFO -  PID 3776 | console.error: SearchService: "#init: failure initializing search:" (new TypeError("can't access property \"BrowserSearch\", win is null", "resource://gre/modules/SearchService.jsm", 3218))
[task 2022-06-23T05:45:50.260Z] 05:45:50     INFO -  PID 3776 | console.debug: SearchService: "#ensureInitialized: failure"
[task 2022-06-23T05:45:50.260Z] 05:45:50     INFO -  Unexpected exception NS_ERROR_FAILURE: SearchService previously failed to initialize
[task 2022-06-23T05:45:50.261Z] 05:45:50     INFO -  #ensureInitialized@resource://gre/modules/SearchService.jsm:1205:26
[task 2022-06-23T05:45:50.261Z] 05:45:50     INFO -  get defaultEngine@resource://gre/modules/SearchService.jsm:157:28
[task 2022-06-23T05:45:50.261Z] 05:45:50     INFO -  getDefaultEngineInfo@resource://gre/modules/SearchService.jsm:228:1
[task 2022-06-23T05:45:50.261Z] 05:45:50     INFO -  #recordTelemetryData@resource://gre/modules/SearchService.jsm:2885:21
[task 2022-06-23T05:45:50.262Z] 05:45:50     INFO -  #init@resource://gre/modules/SearchService.jsm:1295:30
[task 2022-06-23T05:45:50.262Z] 05:45:50     INFO -  _do_main@/builds/worker/workspace/build/tests/xpcshell/head.js:240:6
[task 2022-06-23T05:45:50.262Z] 05:45:50     INFO -  _execute_test@/builds/worker/workspace/build/tests/xpcshell/head.js:597:5
[task 2022-06-23T05:45:50.262Z] 05:45:50     INFO -  @-e:1:1
[task 2022-06-23T05:45:50.263Z] 05:45:50     INFO -  exiting test
[task 2022-06-23T05:45:50.263Z] 05:45:50     INFO -  PID 3776 | JavaScript error: /builds/worker/workspace/build/tests/xpcshell/head.js, line 242: uncaught exception: 2147500037
[task 2022-06-23T05:45:50.263Z] 05:45:50     INFO -  "CONSOLE_MESSAGE: (error) [JavaScript Error: "uncaught exception: 2147500037" {file: "/builds/worker/workspace/build/tests/xpcshell/head.js" line: 242}]"
[task 2022-06-23T05:45:50.264Z] 05:45:50  WARNING -  TEST-UNEXPECTED-FAIL | xpcshell.ini:browser/components/extensions/test/xpcshell/test_ext_settings_overrides_defaults.js | setup - [setup : 271] A promise chain failed to handle a rejection: 2147500037 - stack: (No stack available.)
[task 2022-06-23T05:45:50.264Z] 05:45:50     INFO -  Rejection date: Thu Jun 23 2022 05:45:49 GMT+0000 (Coordinated Universal Time) - false == true
[task 2022-06-23T05:45:50.265Z] 05:45:50     INFO -  resource://testing-common/PromiseTestUtils.jsm:assertNoUncaughtRejections:271
[task 2022-06-23T05:45:50.265Z] 05:45:50     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_execute_test:598
[task 2022-06-23T05:45:50.265Z] 05:45:50     INFO -  -e:null:1
[task 2022-06-23T05:45:50.265Z] 05:45:50     INFO -  exiting test
[task 2022-06-23T05:45:50.265Z] 05:45:50     INFO -  "Force a GC"
[task 2022-06-23T05:45:50.266Z] 05:45:50     INFO -  "CONSOLE_MESSAGE: (info) 1655963149863	addons.manager	DEBUG	before shutdown"
[task 2022-06-23T05:45:50.266Z] 05:45:50     INFO -  "CONSOLE_MESSAGE: (info) 1655963149863	addons.manager	DEBUG	shutdown"
[task 2022-06-23T05:45:50.267Z] 05:45:50     INFO -  "CONSOLE_MESSAGE: (info) 1655963149864	addons.manager	DEBUG	Calling shutdown blocker for XPIProvider"
[task 2022-06-23T05:45:50.267Z] 05:45:50     INFO -  "CONSOLE_MESSAGE: (info) 1655963149864	addons.xpi	DEBUG	shutdown"
[task 2022-06-23T05:45:50.268Z] 05:45:50     INFO -  "CONSOLE_MESSAGE: (info) 1655963149864	addons.xpi-utils	DEBUG	shutdown"
[task 2022-06-23T05:45:50.268Z] 05:45:50     INFO -  "CONSOLE_MESSAGE: (info) 1655963149868	addons.manager	DEBUG	Async provider shutdown done"
[task 2022-06-23T05:45:50.268Z] 05:45:50     INFO -  <<<<<<<
[task 2022-06-23T05:45:55.850Z] 05:45:55     INFO -  Created a conditioned-profile copy: /tmp/tmpawu84h8c/profile
[task 2022-06-23T05:45:55.854Z] 05:45:55     INFO -  TEST-START | xpcshell.ini:browser/components/extensions/test/xpcshell/test_ext_settings_overrides_search_mozParam.js

Comment 1

[Sandor Molnar[:smolnar]]

@Joel, can you take a look at this failure?
started to perma-fail on central after bug 1769154 landed

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1769154

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

this is odd, it fails on mozilla-central only, but passes on autoland and try. This is linux only.

:standard8, I see that you are the main author of this test- any ideas why running this test fails on linux mozilla-central only while having a full conditioned profile (instead of a blank profile) ?

Comment 4

[Mark Banner (:standard8)]

(In reply to Joel Maher ( :jmaher ) (UTC -0800) from comment #3)

this is odd, it fails on mozilla-central only, but passes on autoland and try. This is linux only.

:standard8, I see that you are the main author of this test- any ideas why running this test fails on linux mozilla-central only while having a full conditioned profile (instead of a blank profile) ?

No idea regards to autoland vs m-c, could just be timing.

The search service is trying to put up a dialog that the user's default search engine has been removed, and as a window doesn't exist, it fails.

In this case the reason for us putting up the dialog is that by having a conditioned profile, you're defining a default search engine for the user and as the tests are replacing the configuration this then makes it look like we've removed the "user's" engine, when we haven't.

Overall, I'm surprised this isn't happening for more tests, since we do the same thing in many of the search service and other related tests - part of the useful thing with xpcshell-test is the expectation that you don't have existing profiles/settings to deal with.

btw, this is the first I've heard about conditioned profiles, should there be some sort of dev-planning notice about it? (I haven't been able to locate one).

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

you can see all the tests that are skipped on conditioned profiles by searching for condprof in the .ini manifest files. We run a subset of tests, only on mochitest-plain/xpcshell for linux/windows10 opt/ship.

In most of the failure cases it is disabled by design, which it sounds like this specific test case would fall under. Given the knowledge that we are running the tests in that manifest would you have expected other tests to fail as well?

Comment 6

[Mark Banner (:standard8)]

(In reply to Joel Maher ( :jmaher ) (UTC -0800) from comment #5)

In most of the failure cases it is disabled by design, which it sounds like this specific test case would fall under. Given the knowledge that we are running the tests in that manifest would you have expected other tests to fail as well?

Ok, what I didn't realise is that this is only a subset of tests from the whole tree. For example, I'd expect toolkit/components/search to have lots of failures, but that isn't being run.

I did some digging and worked out how to download the profile - which explains all.

The generated search settings in the profile have (among other things), the channel set as "nightly". In the code for the notification, we have an exclusion so that if the channel is different, we do not display the notification. Since autoland and try don't have a channel set, we'll never display the notification. On central we will, and hence the failures.

So I think I agree this case would be correct to skip - we'd effectively want to drop any existing settings anyway for it, and there's nothing to be gained from having settings there (we do have a few search specific xpcshell-tests which run with existing saved settings).

Comment 7

[Intermittent Failures Robot]

15 failures in 3075 pushes (0.005 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 15

Platform and build breakdown:

• linux1804-64-shippable-qr: 15
  • opt: 15

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1776135&startday=2022-06-20&endday=2022-06-26&tree=all

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1769154

Comment 9

[Andreea Pavel [:apavel]]

Attachment: Bug 1776135 - disable test_ext_settings_overrides_defaults.js on condprof r=standard8

Comment 10

[Intermittent Failures Robot]

24 failures in 3312 pushes (0.007 failures/push) were associated with this bug in the last 7 days.

This is the #39 most frequent failure this week.

Repository breakdown:

• mozilla-central: 24

Platform and build breakdown:

• linux1804-64-shippable-qr: 24
  • opt: 24

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1776135&startday=2022-06-27&endday=2022-07-03&tree=all

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/162cc1d0f5db
disable test_ext_settings_overrides_defaults.js on condprof r=Standard8 DONTBUILD

Comment 12

[Mark Banner (:standard8)]

We don't need to leave-open, I don't think we're going to support condprof for this test, there's not really any point to it.

Comment 13

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/162cc1d0f5db

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:apavel, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox103 to wontfix.

For more information, please visit auto_nag documentation.

Comment 15

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

condprof doesn't run for beta.

Comment 16

[Intermittent Failures Robot]

3 failures in 3072 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 3

Platform and build breakdown:

• linux1804-64-shippable-qr: 3
  • opt: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1776135&startday=2022-07-04&endday=2022-07-10&tree=all