Closed Bug 1776157 Opened 2 months ago Closed 2 months ago

Bookmarks sidebar flashes white when opened in dark mode

Categories

(Core :: Layout, defect)

Firefox 102
defect

Tracking

()

VERIFIED FIXED
103 Branch
Tracking Status
firefox-esr91 --- unaffected
firefox-esr102 102+ verified
firefox101 --- unaffected
firefox102 --- verified
firefox103 --- verified

People

(Reporter: ke5trel, Assigned: emilio)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

STR:

  1. Enable built-in Dark theme.
  2. Press Ctrl+B to rapidly open and close the bookmarks sidebar.

Sidebar flashes white where previously it remained dark.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0d8f25c4388af0894425506e71024044f4d3402a&tochange=f0c4c97a8e6aa34214f287cb499321b6a0186c2f

Regressed by Bug 1738380.

:emilio, since you are the author of the regressor, bug 1738380, could you take a look?
For more information, please visit auto_nag documentation.

Flags: needinfo?(emilio)
Assignee: nobody → emilio
Flags: needinfo?(emilio)

It causes unnecessary flashes in some cases, like the sidebar which
intentionally loads about:blank.

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8b1fbea4db86
Don't force chrome frames to be opaque. r=dholbert
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox102 to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(emilio)

Comment on attachment 9282536 [details]
Bug 1776157 - Don't force chrome frames to be opaque. r=#layout

Beta/Release Uplift Approval Request

  • User impact if declined: comment 0
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: comment 0
  • List of other uplifts needed: none
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Restoring previous behavior for chrome frames.
  • String changes made/needed: none
  • Is Android affected?: No
Flags: needinfo?(emilio)
Attachment #9282536 - Flags: approval-mozilla-beta?
Attachment #9282536 - Flags: approval-mozilla-beta? → approval-mozilla-release?
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

I was able to reproduce the issue on Win10 using build 103.0a1(20220531214721).
Verified as fixed on Win10 / Ubuntu 20.4 / Mac10.13 using builds 104.0a1(20220628191450) and 103.0b2(20220628190840).

Status: RESOLVED → VERIFIED
Flags: qe-verify+

Could you request uplift to ESR102 as well? Thanks

Flags: needinfo?(emilio)

Comment on attachment 9282536 [details]
Bug 1776157 - Don't force chrome frames to be opaque. r=#layout

Approved for 102.0.1, thanks.

Attachment #9282536 - Flags: approval-mozilla-release? → approval-mozilla-release+

Comment on attachment 9282536 [details]
Bug 1776157 - Don't force chrome frames to be opaque. r=#layout

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Trivial fix.
  • User impact if declined: Simple fix for flashing in some cases.
  • Fix Landed on Version: 103
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Early bail out for chrome pages to restore old behavior in privileged iframes.
Flags: needinfo?(emilio)
Attachment #9282536 - Flags: approval-mozilla-esr102?

Verified as fixed on Win10/Mac10.13/Ubuntu20.4 using 102.0.1(20220705093820).

Comment on attachment 9282536 [details]
Bug 1776157 - Don't force chrome frames to be opaque. r=#layout

Approved for ESR102.0.1, thanks.

Attachment #9282536 - Flags: approval-mozilla-esr102? → approval-mozilla-esr102+

Verified as fixed on Win10/Mac10.13/Ubuntu20.4 using build 102.0.1esr(20220711174428).

You need to log in before you can comment on or make changes to this bug.