1776157 - Bookmarks sidebar flashes white when opened in dark mode

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[Kestrel]

Attachment: Video showing sidebar flashing white when opened

STR:

1. Enable built-in Dark theme.
2. Press Ctrl+B to rapidly open and close the bookmarks sidebar.

Sidebar flashes white where previously it remained dark.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0d8f25c4388af0894425506e71024044f4d3402a&tochange=f0c4c97a8e6aa34214f287cb499321b6a0186c2f

Regressed by Bug 1738380.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1738380, could you take a look?
For more information, please visit auto_nag documentation.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1776157 - Don't force chrome frames to be opaque. r=#layout

It causes unnecessary flashes in some cases, like the sidebar which
intentionally loads about:blank.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b1fbea4db86
Don't force chrome frames to be opaque. r=dholbert

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/8b1fbea4db86

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox102 to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9282536 [details]
Bug 1776157 - Don't force chrome frames to be opaque. r=#layout

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Restoring previous behavior for chrome frames.
• String changes made/needed: none
• Is Android affected?: No

Comment 7

[Monica Chiorean]

I was able to reproduce the issue on Win10 using build 103.0a1(20220531214721).
Verified as fixed on Win10 / Ubuntu 20.4 / Mac10.13 using builds 104.0a1(20220628191450) and 103.0b2(20220628190840).

Comment 8

[Pascal Chevrel:pascalc (PTO until April 26)]

Could you request uplift to ESR102 as well? Thanks

Comment 9

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9282536 [details]
Bug 1776157 - Don't force chrome frames to be opaque. r=#layout

Approved for 102.0.1, thanks.

Comment 10

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-release/rev/83b3d07ae631

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9282536 [details]
Bug 1776157 - Don't force chrome frames to be opaque. r=#layout

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Trivial fix.
• User impact if declined: Simple fix for flashing in some cases.
• Fix Landed on Version: 103
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Early bail out for chrome pages to restore old behavior in privileged iframes.

Comment 12

[Monica Chiorean]

Verified as fixed on Win10/Mac10.13/Ubuntu20.4 using 102.0.1(20220705093820).

Comment 13

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9282536 [details]
Bug 1776157 - Don't force chrome frames to be opaque. r=#layout

Approved for ESR102.0.1, thanks.

Comment 14

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-esr102/rev/df6efb39c3efeb68a7a262cdda0bb1a9e7bbbca6 ESR 102
https://hg.mozilla.org/releases/mozilla-esr102/rev/f2b60ae623342aa38cdbcae686d1bdb9b4ecc459 FIREFOX_ESR_102_0_X_RELBRANCH

Comment 15

[Monica Chiorean]

Verified as fixed on Win10/Mac10.13/Ubuntu20.4 using build 102.0.1esr(20220711174428).