1776254 - Cannot build library for SM embedding examples, missing ProfilingCategoryList.h

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P3)

Description

[Yury Delendik (:yury)]

The following https://github.com/mozilla-spidermonkey/spidermonkey-embedding-examples/blob/esr91/docs/Building%20SpiderMonkey.md , but I build on esr102 branch.

As soon as I try building examples, I get:
In file included from sm-bench.cpp:1:
In file included from /Users/yury/bin/mozjs/include/mozjs-102/jsapi.h:30:
In file included from /Users/yury/bin/mozjs/include/mozjs-102/js/CallAndConstruct.h:15:
In file included from /Users/yury/bin/mozjs/include/mozjs-102/js/RootingAPI.h:27:
In file included from /Users/yury/bin/mozjs/include/mozjs-102/js/ProfilingStack.h:16:
/Users/yury/bin/mozjs/include/mozjs-102/js/ProfilingCategory.h:13:10: fatal error: 'js/ProfilingCategoryList.h' file not found
#include "js/ProfilingCategoryList.h" // MOZ_PROFILING_CATEGORY_LIST
^~~~~~~~~~~~~~~~~~~~~~~~~~~~

(Workaround: copying ProfilingCategoryList.h to include/mozjs-102/js/ fixes things)

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

NI myself, as this has come up multiple times and I may have cycles to look at this in the next bit.

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Ok; I lied. I'm not going to get to this any time soon.

Comment 3

[Philip Chimento [:ptomato]]

Attachment: Bug 1776254 - Install ProfilingCategoryList.h (r?arai)

When installing embedded SpiderMonkey, we need to install the generated
header ProfilingCategoryList.h into /usr/include/mozjs-___/js/ because
that's where the rest of the SpiderMonkey code expects to find it.
It's not automatically installed already, because it's generated.

Thanks to Arai for the suggestion of where to look.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb2b21f037a5
Install ProfilingCategoryList.h (r=arai)

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/eb2b21f037a5

Comment 6

[Philip Chimento [:ptomato]]

Comment on attachment 9286696 [details]
Bug 1776254 - Install ProfilingCategoryList.h (r?arai)

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Installing this header is required for compiling programs that use embedded SpiderMonkey. Without it, embedder programs will get compile errors.
• User impact if declined: In practice, downstreams would have to carry this patch themselves anyway, or manually copy the header during their build processes.
• Fix Landed on Version: 104
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The change is not part of the build for Firefox. If something were somehow to go wrong anyway in the Firefox build, it would be an error at build time, not at run time, and so would be obvious.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9286696 [details]
Bug 1776254 - Install ProfilingCategoryList.h (r?arai)

Approved for 102.2esr. Thanks for staying on top of these issues, as always, Philip!

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr102/rev/33147b91e42b