Closed Bug 1776291 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 34567 - Rename popup=async to popup=manual

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
104 Branch
Tracking Status
firefox104 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Attachments

(1 file)

Sync web-platform-tests PR 34567 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/34567
Details from upstream follow.

Mason Freed <masonf@chromium.org> wrote:

Rename popup=async to popup=manual

Per the [1] resolution, we have decided to rename popup=async to
popup=manual, since it is a) parallel to popup=auto, and b) easier
to understand.

[1] https://github.com/openui/open-ui/issues/495#issuecomment-1164827851

Bug: 1307772
Change-Id: I786f6332c2a7f9df4810aeedfd425e38579ea1b1
Reviewed-on: https://chromium-review.googlesource.com/3722345
WPT-Export-Revision: cc36174666109e66bf64a8622f389bbe217edbef

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
PR 34567 applied with additional changes from upstream: 350691e98b712351b5da4fc511a0f17a9cbec52e, cd6f245502e992ef25dc2828f91f05a5f7dd689e
Attached file Notable wpt changes
# CI Results Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 6 tests and 3 subtests ## Status Summary ### Firefox `OK` : 4 `FAIL` : 1215 `ERROR`: 1 ### Chrome `OK` : 3 `FAIL` : 41 `ERROR`: 2 ### Safari `OK` : 4 `FAIL` : 1212 `ERROR`: 1 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=2245dc7875f6cfd5c6b44a984a0924e46691ab89) [GitHub PR Head](https://wpt.fyi/results/?sha=d54cdb615c3cf35cb79b000f06ebbb8dd890a246&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=d54cdb615c3cf35cb79b000f06ebbb8dd890a246&label=pr_base) ## Details (See attachment for full changes)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/99c887c29569 [wpt PR 34567] - Rename popup=async to popup=manual, a=testonly https://hg.mozilla.org/integration/autoland/rev/e11f3d7b08be [wpt PR 34567] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: