1776377 - Start using private fields in MessageHandler

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P1)

Description

[Alexandra Borovova [:Sasha]]

At the moment, we use in MessageHandler (https://searchfox.org/mozilla-central/source/remote/shared/messagehandler/MessageHandler.jsm) prefix _ to indicate internal properties. Instead, we should use JavaScript private fields to make it consistent with other classes.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Examples for private fields can be found in the following log module for WebDriver BiDi:
https://searchfox.org/mozilla-central/rev/5b2d2863bd315f232a3f769f76e0eb16cdca7cb0/remote/webdriver-bidi/modules/windowglobal/log.jsm

This looks like a nice bug for mentoring.

Comment 2

[harshraitth2]

Hello, I am new to open source contribution and want to start my journey with it, I would love to take on this issue but i do not know where to start. Can someone help?

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Hi Harshraitth2! Sorry for the delay in the response but I was away and just got back. It's great to hear that you want to contribute to our project and also learn new stuff. To get started I would propose to have a look at https://firefox-source-docs.mozilla.org/contributing/index.html for a generic getting started guide.

Then the related code that needs modification is under /remote/shared/messagehandler. Feel free to ask any questions in https://chat.mozilla.org/#/room/#webdriver:mozilla.org as well in case you have issues.

Comment 4

[harshraitth2]

Hey whimboo, I followed the getting started guide for starting with the contribution, and i have also made changes in the specified file, while raising a revsion it says no reviewers added, so i think i messed up somewhere while committing the changes.

Comment 5

[harshraitth2]

Attachment: Bug 1776377 changed MessageHandler classes to use private class fields. r=whimboo

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba39a7d457b7
changed MessageHandler classes to use private class fields. r=webdriver-reviewers,jdescottes

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/ba39a7d457b7