1776451 - Crash after profile import in [@ nsMsgAccountManager::Shutdown]

Status: RESOLVED FIXED

(MailNews Core :: Account Manager, defect)

Description

[Wayne Mery (:wsmwk)]

Crash happened immediately after import of a simple two account Thunderbird profile into a new, empty profile. I clicked to finish the process and expected Thunderbird to restart, but it crashed - I assume on shutdown.

On startup (after submitting the crash report) the import looks like it was successful - everything seems to be there from the imported profile.

Crash report: https://crash-stats.mozilla.org/report/index/204df22e-f708-4c81-9742-10b2a0220624

Reason: EXCEPTION_ACCESS_VIOLATION_READ

Top 10 frames of crashing thread:

0 xul.dll nsMsgAccountManager::Shutdown mailnews/base/src/nsMsgAccountManager.cpp:196
1 xul.dll nsMsgAccountManager::Observe mailnews/base/src/nsMsgAccountManager.cpp:246
2 xul.dll nsObserverList::NotifyObservers xpcom/ds/nsObserverList.cpp:70
3 xul.dll nsObserverService::NotifyObservers xpcom/ds/nsObserverService.cpp:291
4 xul.dll static mozilla::AppShutdown::AdvanceShutdownPhaseInternal xpcom/base/AppShutdown.cpp:372
5 xul.dll nsXREDirProvider::DoShutdown toolkit/xre/nsXREDirProvider.cpp:985
6 xul.dll ScopedXPCOMStartup::~ScopedXPCOMStartup toolkit/xre/nsAppRunner.cpp:2056
7 xul.dll mozilla::UniquePtr<ScopedXPCOMStartup, mozilla::DefaultDelete<ScopedXPCOMStartup> >::operator= mfbt/UniquePtr.h:275
8 xul.dll XREMain::XRE_main toolkit/xre/nsAppRunner.cpp:5971
9 xul.dll XRE_main toolkit/xre/nsAppRunner.cpp:6006

Comment 1

[WaltS48 [:walts48]]

I had that crash testing Import on Fedora 35

https://crash-stats.mozilla.org/report/index/6e52446b-8aea-4ed9-bd6f-016b10220624

Comment 2

[Wayne Mery (:wsmwk)]

Simple STR: create a new profile, cancel account creation, shutdown, crash

Comment 3

[Rachel Martin]

Bug 1774072 comment #16.

Comment 4

[Sean Burke [:leftmostcat]]

Attachment: Bug 1776451 - prevent crash during account manager shutdown if folder cache isn't initialized. r=aleca

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4f78bd01de3e
prevent crash during account manager shutdown if folder cache isn't initialized. r=aleca

Comment 6

[Alessandro Castellani [:aleca]]

Margin this for ESR tracking since it looks like the patch that caused this crash will need to be uplifted to ESR.

Comment 7

[Rob Lemley [:rjl]]

Comment on attachment 9282877 [details]
Bug 1776451 - prevent crash during account manager shutdown if folder cache isn't initialized. r=aleca

[Approval Request Comment]
Regression caused by (bug #): 1774072
User impact if declined: Crash after running import
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):

[Triage Comment]
Approved for 102 and 103beta

Comment 8

[Rachel Martin]

Already on beta since it landed on 103.

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 102.0.1:
https://hg.mozilla.org/releases/comm-esr102/rev/ab3aebdeba5c