1776833 - GC tunables require a lock to access even though that are only accessed on the main thread

Status: RESOLVED FIXED

(Core :: JavaScript: GC, task, P3)

Description

[Jon Coppeard (:jonco)]

This has been true since we removed off-thread allocation.

The one exception to to this is the settings for min/max number of free chunks, which is used by background allocation.

This is a tidyup as a prelude to bug 1770768.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1776833 - Part 1: Make GC tunables MainThreadData or move them to GCRuntime r?sfink

The chunk settings move to GCRuntime where they are made GCLockData.

Almost all tunable settings become MainThreadData with the exception of
mallocThresholdBase which is accessed off-thread during sweeping since resizing
contains can cause allocation.

Comment 2

[Jon Coppeard (:jonco)]

Attachment: Bug 1776833 - Part 2: Remove use of GC lock when accessing GC tunables r?sfink

Depends on D150458

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/416f094f92a1
Part 1: Make GC tunables MainThreadData or move them to GCRuntime r=sfink
https://hg.mozilla.org/integration/autoland/rev/b8740c0dade3
Part 2: Remove use of GC lock when accessing GC tunables r=sfink

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/416f094f92a1
https://hg.mozilla.org/mozilla-central/rev/b8740c0dade3