1776870 - Integrate the automated rewrite script into mach

Status: RESOLVED FIXED

(Core :: XPConnect, task)

Comment 1

[Tooru Fujisawa [:arai]]

https://github.com/arai-a/jsm-to-esm

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1776870 - Integrate esmify script into mach. r=yulia!

Comment 3

[Marco Castelluccio [:marco]]

Would it be feasible to warn on any new usage of ChromeUtils.import and suggest using ES6 modules instead, or is it too early?

Comment 4

[Tooru Fujisawa [:arai]]

(In reply to Marco Castelluccio [:marco] from comment #3)

Would it be feasible to warn on any new usage of ChromeUtils.import and suggest using ES6 modules instead, or is it too early?

IMO it's too early.
but yeah, once almost all modules are ESMified, we can add that warning.

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Patch that adds ./mach esmify --verify-map command

The map.json in https://phabricator.services.mozilla.com/D150494 is verified with this command.
it extracts all chrome:// and resource:// mappings manually and checks each of them.
the code is too hacky, so I'm not sure if it worth landing.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6779169ea4a4
Integrate esmify script into mach. r=yulia,firefox-static-analysis-reviewers,andi

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/6779169ea4a4