1777146 - Reference to removed file CaptivePortalWatcher.jsm

Status: RESOLVED FIXED

(Firefox :: General, task, P3)

Description

[Tooru Fujisawa [:arai]]

CaptivePortalWatcher.jsm no longer exists.

https://searchfox.org/mozilla-central/rev/0069a0cdc3cd136ea7411521219df6665f260be7/browser/base/content/test/captivePortal/head.js#5-9

ChromeUtils.defineModuleGetter(
  this,
  "CaptivePortalWatcher",
  "resource:///modules/CaptivePortalWatcher.jsm"
);

https://hg.mozilla.org/mozilla-central/rev/7957edd71a116c3dbb3132985e9e3f8d0de2a3e1

Comment 1

[camastromonaco]

Hello Y'all,
I am new Firefox contributor and was wondering if I could be assigned this bug? I think this would be a great bug for me to learn more about the procedure Firefox changes abide by. I do have a couple questions, which are probably incredibly nooby. If someone would be kind enough to provide answers to, then that would be greatly appreciated:

1. From my understanding, the objective is to simply remove the reference to CaptivePortalWatcher.jsm JS module file (as depicted in the reporter's post). Is that correct?

2. Is the source code in a github repository, gitlab, or some other version control software? I see that the researcher provided a link to the source code file, but I am wondering how I go about contributing via whatever version control software firefox contributors use. I see that https://searchfox.org/mozilla-central/source/ has the source code (I think) and that it has a .gitignore file, which leads me to believe it is a github repo, but I am not sure if that mozilla-central is the repo or just a copy of the one that exists (potentially) on github.

3. So, if #1 and #2 are relatively on point, then I am imagining that I simply clone the repository, create a branch, remove the reference to CaptivePortalWatcher.jsm, and create a pull request with, I would hypothesize, the mentor as the reviewer. If that is not quite or not at all the right procedure to follow, then please correct me. I looked through a lot of the documentation and I ended up feeling incredibly drowned as opposed to understanding exactly what to do.

I appreciate your time and would love to help out,
cheers

Comment 2

[Tooru Fujisawa [:arai]]

Thank you for looking into it!

1

Yes, the file is removed but one unused reference is kept in the source, and that needs to be removed here.

2

The document https://firefox-source-docs.mozilla.org/setup/index.html describes how to setup development environment, including cloning repository, and submit patch.
Please follow the document, from "Setting Up Your Machine" section.
If you have any questions, feel free to ask here, or in https://chat.mozilla.org/#/room/#introduction:mozilla.org

3

Yes. the patch should be submitted to phabricator.services.mozilla.com/ , with moz-phab command, explained in the document.
You can ask review from mstriemer, by putting "r?mstriemer" at the end of the commit message.

Comment 3

[camastromonaco]

Thank you for the clarification! Before I start my endeavor to complete this bug patch (following your previous clarifications), do I need to wait for the bug to be assigned to me first?

Comment 4

[Tooru Fujisawa [:arai]]

you don't have to wait.
the bug is assigned when you submit a patch.

Comment 5

[camastromonaco]

Got it! Thank you!

Comment 6

[camastromonaco]

Attachment: Bug 1777146 - Removed extraneous CaptivePortalWatcher reference r?mstriemer

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/97ef44567271
Removed extraneous CaptivePortalWatcher reference r=mstriemer

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/97ef44567271