1777218 - Remove unused XMLHTTPRequestMainThread::SetRequestObserver()

Status: RESOLVED FIXED

(Core :: DOM: Networking, task, P3)

Description

[Manuel Bucher [:manuel]]

XMLHTTPRequestMainThread::SetRequestObserver() is unused. Therefore mRequestObserver is always nullptr and can be removed alongside this function.

Comment 1

[Ho Cheung]

Can I take over and work on this bug?

Comment 2

[Manuel Bucher [:manuel]]

Sure :). Feel free to take on this bug. You can reach out if you need any help.

Comment 3

[Ho Cheung]

(In reply to Manuel Bucher [:manuel] from comment #2)

Sure :). Feel free to take on this bug. You can reach out if you need any help.

Ok, I will submit a commit about this bug in the near future

In addition, I would like to ask, is there anything else that needs to be paid attention to when dealing with this bug?

Comment 4

[Manuel Bucher [:manuel]]

Thanks. It looks like there is at least one more dead code path that needs to get removed alongside, because mRequestObserver is always nullptr:

https://searchfox.org/mozilla-central/rev/daf613efc5c358f3a94961d73b90472c00703838/dom/xhr/XMLHttpRequestMainThread.cpp#1823-1826

if (!mFirstStartRequestSeen && mRequestObserver) {
  mFirstStartRequestSeen = true;
  mRequestObserver->OnStartRequest(request);
}

And mFirstStartRequestSeen won't be set to true anywhere and can get removed as well.

After removing the variables, make sure that everything is still compiling. With that, it will probably be ready to land.

Comment 5

[Ho Cheung]

Attachment: Bug 1777218 - Remove unused XMLHTTPRequestMainThread::SetRequestObserver() r=manuel

Remove unused XMLHTTPRequestMainThread::SetRequestObserver() in code

Comment 6

[Ho Cheung]

(In reply to Manuel Bucher [:manuel] from comment #4)

Thanks. It looks like there is at least one more dead code path that needs to get removed alongside, because mRequestObserver is always nullptr:

https://searchfox.org/mozilla-central/rev/daf613efc5c358f3a94961d73b90472c00703838/dom/xhr/XMLHttpRequestMainThread.cpp#1823-1826

if (!mFirstStartRequestSeen && mRequestObserver) {
  mFirstStartRequestSeen = true;
  mRequestObserver->OnStartRequest(request);
}

And mFirstStartRequestSeen won't be set to true anywhere and can get removed as well.

After removing the variables, make sure that everything is still compiling. With that, it will probably be ready to land.

@manuel, please review the new commit

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b3ad0e8e792
Remove unused XMLHTTPRequestMainThread::SetRequestObserver() r=manuel

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/3b3ad0e8e792