1777249 - Elements shouldn't use --theme-selection-background-hover for non-focused/hovered/active element

Status: RESOLVED FIXED

(DevTools :: Shared Components, task)

Description

[Nicolas Chevobbe [:nchevobbe]]

A proper variable should be created for when the tool need a backround-color that stands out

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1777249 - [devtools] Create CSS variable for alternate element background instead of abusing --theme-selection-background-hover. r=bomsy.

In a few places we were using the variable to have a different background than
the ones we have everywhere (blueish on light theme, dark-grey blue in dark mode).
In order to avoid any confusion, this patch adds a dedicated variable with a name
that should be more explicit.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6040e53370dc
[devtools] Create CSS variable for alternate element background instead of abusing --theme-selection-background-hover. r=bomsy.

Comment 3

[Cristian Tuns]

Backed out for causing mochitest on failures browser_console_evaluation_context_selector.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | devtools/client/webconsole/test/browser/browser_console_evaluation_context_selector.js | context selector is only displayed when Fission or EFT is enabled - Got [object HTMLButtonElement], expected null

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb3ef8a93a1a
[devtools] Create CSS variable for alternate element background instead of abusing --theme-selection-background-hover. r=bomsy.

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/fb3ef8a93a1a