1777251 - OpenPGP external GnuPG: Failure to attach public key, if it's configured with the ID of a subkey

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect, P1)

Description

[Kai Engert (:KaiE:)]

When using the external GnuPG mechanism, the user may specify the ID of a subkey for various reasons.

The recently introduced functionality from bug 1629309 fails if a subkey ID is given.

We must automatically use the related primary key instead.

Comment 1

[Kai Engert (:KaiE:)]

Attachment: Bug 1777251 - Always use primary key when exporting a reduced public key. r=PatrickBrunschwig

Comment 2

[Kai Engert (:KaiE:)]

For the time being, to work around this bug, you may manually disable attaching your public key (attachment menu) while composing a signed/encrypted message - and optionally - manually attach a file with your public key.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4f8ca2329ab3
Always use primary key when exporting a reduced public key. r=PatrickBrunschwig

Comment 4

[Kai Engert (:KaiE:)]

Comment on attachment 9283409 [details]
Bug 1777251 - Always use primary key when exporting a reduced public key. r=PatrickBrunschwig

[Approval Request Comment]
Regression caused by (bug #): 1629309
User impact if declined: failure to send email for affected users
Testing completed (on c-c, etc.): yes
Risk to taking this patch (and alternatives if risky): low

Comment 5

[Rob Lemley [:rjl]]

Comment on attachment 9283409 [details]
Bug 1777251 - Always use primary key when exporting a reduced public key. r=PatrickBrunschwig

[Approval Request Comment]
Needs to be on beta before going to 102.

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9283409 [details]
Bug 1777251 - Always use primary key when exporting a reduced public key. r=PatrickBrunschwig

[Triage Comment]
Approved for beta

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 103.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/2ddde7a8f1cf

Comment 8

[Wayne Mery (:wsmwk)]

optimistically approving for TB102.0.1 - assuming it will pass beta over the next several days

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 102.0.1:
https://hg.mozilla.org/releases/comm-esr102/rev/c9c6facafc5f

Comment 10

[Rob Lemley [:rjl]]

Backout Thunderbird 102.0.1:
https://hg.mozilla.org/releases/comm-esr102/rev/7f97b55f9e2cdcf45239c47e9f49b1ecf04c887d

Comment 11

[Rob Lemley [:rjl]]

This caused an ESLint failure on comm-esr102 that was not seen on beta:
https://treeherder.mozilla.org/logviewer?job_id=383143679&repo=comm-esr102

TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mail/extensions/openpgp/content/modules/RNP.jsm:2423:27 | 'lazy' is not defined. (no-undef)

Comment 12

[Rob Lemley [:rjl]]

Attachment: 1777251_esr102.patch

Comment 13

[Rob Lemley [:rjl]]

Comment on attachment 9283835 [details] [diff] [review]
1777251_esr102.patch

[Triage Comment]
Approving comm-esr102 version of previously approved patch.

Comment 14

[Rob Lemley [:rjl]]

Thunderbird 102.0.1:
https://hg.mozilla.org/releases/comm-esr102/rev/7d5734d2820f