1777264 - Add telemetry for HDR video playback on macOS

Status: RESOLVED FIXED

(Core :: Graphics, task)

Description

[Jeff Muizelaar [:jrmuizel]]

We don't seem to have telemetry for this yet. It would be good to get a sense for how common HDR playback is.

Comment 1

[Brad Werth [:bradwerth] | Out until March 3]

We'll do video low power telemetry in Bug 1737682, and once that lands, that will give us a sensible template to use for this telemetry also.

Comment 2

[Brad Werth [:bradwerth] | Out until March 3]

From a conversation with Product Team, here are the goals for the telemetry:

1. Of the video played by macOS users, what percentage of it is HDR?
2. How often does a Firefox session include the playback of HDR video?
3. For how long are users watching HDR video?

All of this broken down by region.

Comment 3

[Brad Werth [:bradwerth] | Out until March 3]

Attachment: Bug 1777264 Part 4: Make TelemetryProbesReporter track play time of HDR video.

This doesn't seperately track whether or not the HDR video is visible, as
we do for video generally.

Comment 4

[Brad Werth [:bradwerth] | Out until March 3]

Attachment: Bug 1777264 Part 5: Define and emit VIDEO_HDR_PLAY_TIME_MS.

Depends on D152819

Comment 5

[Brad Werth [:bradwerth] | Out until March 3]

Attachment: Bug 1777264 Part 2: Update VideoInfo color depth with information from decoded frames.

Some information that VideoInfo needs is not available from the metadata
header. This change makes it so that VideoInfo structure is updated with
color depth information as frames come in.

Comment 6

[Brad Werth [:bradwerth] | Out until March 3]

Attachment: Bug 1777264 Part 3: Make MacIOSurfaceImage report color depth accurately.

Depends on D153282

Comment 7

[Brad Werth [:bradwerth] | Out until March 3]

Attachment: Bug 1777264 Part 6: Add a chrome test of HDR telemetry.

This test will only pass on platform that accurately report the color
depth in their VideoInfo structures. Presently that is only macOS, so the
test has a conditional task that only runs on macOS.

Depends on D152820

Comment 8

[Brad Werth [:bradwerth] | Out until March 3]

https://treeherder.mozilla.org/jobs?repo=try&revision=f9ab110e581dc502f08f211f00c9907c8d5b1c4f

Comment 9

[Brad Werth [:bradwerth] | Out until March 3]

Attachment: request_VIDEO_HDR_PLAY_TIME_MS.md

Comment 10

[Travis Long [:travis_]]

Comment on attachment 9287959 [details]
request_VIDEO_HDR_PLAY_TIME_MS.md

Data Review

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, through the Histograms.json file and the Probe Dictionary.

2. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, through the standard telemetry preference in the application settings.

3. If the request is for permanent data collection, is there someone who will monitor the data over time?

Permanent collection to be monitored by Brad Werth <[e-mail]>

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2: Technical data

5. Is the data collection request for default-on or default-off?

Default-on

6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No

7. Is the data collection covered by the existing Firefox privacy notice?

Yes

8. Does the data collection use a third-party collection tool?

No

Result

data-review+

Comment 11

[Brad Werth [:bradwerth] | Out until March 3]

Attachment: Bug 1777264 Part 1: Make MediaDecoder aware of changed TrackInfo as it changes.

When TrackInfo changes in the MediaFormatReader, this ensures that MediaDecoder
has the same information.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c4a071fadda
Part 1: Make MediaDecoder aware of changed TrackInfo as it changes. r=alwu
https://hg.mozilla.org/integration/autoland/rev/2ec8c0fb6613
Part 2: Update VideoInfo color depth with information from decoded frames. r=media-playback-reviewers,alwu
https://hg.mozilla.org/integration/autoland/rev/2a00517ffd28
Part 3: Make MacIOSurfaceImage report color depth accurately. r=media-playback-reviewers,alwu
https://hg.mozilla.org/integration/autoland/rev/caac6179b27f
Part 4: Make TelemetryProbesReporter track play time of HDR video. r=media-playback-reviewers,alwu
https://hg.mozilla.org/integration/autoland/rev/753e0ca024a8
Part 5: Define and emit VIDEO_HDR_PLAY_TIME_MS. r=media-playback-reviewers,alwu
https://hg.mozilla.org/integration/autoland/rev/8c6b4a145528
Part 6: Add a chrome test of HDR telemetry. r=media-playback-reviewers,alwu

Comment 13

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/0c4a071fadda
https://hg.mozilla.org/mozilla-central/rev/2ec8c0fb6613
https://hg.mozilla.org/mozilla-central/rev/2a00517ffd28
https://hg.mozilla.org/mozilla-central/rev/caac6179b27f
https://hg.mozilla.org/mozilla-central/rev/753e0ca024a8
https://hg.mozilla.org/mozilla-central/rev/8c6b4a145528