1777338 - Ctrl+0 no longer resets page zoom when current zoom is 100% and default zoom is not 100%

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Chris Peterson [:cpeterson]]

[Tracking Requested - why for this release]:

@mconley: this bug is a regression in 102 103 from bug 698873. I didn't file this bug earlier because I mistakenly thought bug 1773865 described the same problem.

Steps to reproduce

1. In Firefox settings, change "Default zoom" from 100% to 120% (or any other value besides 100%).
2. Open a web page such as https://www.example.com/
3. Use the Ctrl + - keyboard shortcut to reduce the page zoom from 120% to 110%.
4. Use the Ctrl + 0 keyboard shortcut to reset the page zoom to the default zoom level, 120%.
5. Use the Ctrl + - keyboard shortcut to reduce the page zoom from 120% to 100%.
6. Use the Ctrl + 0 keyboard shortcut to reset the page zoom to the default zoom level, 120%.

Expected result

The page zoom should reset to the default zoom level, 120%.

Actual result

Nothing happens. The page zoom does not reset to the default zoom value if the current zoom level is 100%.

Comment 1

[Pascal Chevrel (relman team) -> :pascalc|PTO until Sept 2]

The regressing bug landed in 103, is that affecting 102?

Comment 2

[Mike Conley (:mconley) (:⚙️) (PTO Aug 24-28)]

The regressor landed in 103, so 102 should be fine.

Comment 3

[Mike Conley (:mconley) (:⚙️) (PTO Aug 24-28)]

Attachment: Bug 1777338 - Make sure zoom command updater takes a user-set default zoom level into account. r?NeilDeakin!

The patch for bug 698873 assumed that the default zoom level is 1.0, when the user can
actually change that value.

Interestingly, we have to asynchronously query for the default value, so for simplicities
sake, I've had to update the test I wrote to poll for the commands to be in the right
state.

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/81a09589dba3

Comment 5

[Chris Peterson [:cpeterson]]

(In reply to Pascal Chevrel:pascalc from comment #1)

The regressing bug landed in 103, is that affecting 102?

102 is fine. I mistyped my bug description in comment 0.

Beta 103 is still affected.

Comment 6

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:mconley, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox103 to wontfix.

For more information, please visit auto_nag documentation.

Comment 7

[Mike Conley (:mconley) (:⚙️) (PTO Aug 24-28)]

Comment on attachment 9283568 [details]
Bug 1777338 - Make sure zoom command updater takes a user-set default zoom level into account. r?NeilDeakin!

Beta/Release Uplift Approval Request

• User impact if declined: Users who have set a zoom level default to be any value other than 100% will find that if they're at the 100% zoom level, that they cannot reset to their default zoom level.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): We were hard-coding a value of 1.0 instead of the user's default zoom level when doing the check to see whether or not the reset command should be enabled. That's a pretty simple fix.
• String changes made/needed: None.
• Is Android affected?: No

Comment 8

[Donal Meehan [:dmeehan]]

Comment on attachment 9283568 [details]
Bug 1777338 - Make sure zoom command updater takes a user-set default zoom level into account. r?NeilDeakin!

Approved for 103.0b5, thanks.

Comment 9

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/1cb76b0d5baa

Comment 10

[Monica Chiorean (OOO August 21st 5:30PM)]

Reproduced issue on Win10 using build 104.0a1 (20220629215821).
Verified as fixed on Win10/Ubuntu20.4/Mac 10.13 on Beta 103.0b6 (20220707185904) and Nightly 104.0a1 (20220707214915).