1777394 - Crash in [@ RLBoxHunspell::Create]

Status: RESOLVED FIXED

(Core :: Spelling checker, defect)

Description

[Wayne Mery (:wsmwk)]

#12 crash for version 102

Crash report: https://crash-stats.mozilla.org/report/index/b4cdfd65-9c3d-44a7-a054-c81590220423

MOZ_CRASH Reason: MOZ_RELEASE_ASSERT(dictSizeResult.isOk())

Top 10 frames of crashing thread:

0 xul.dll static RLBoxHunspell::Create extensions/spellcheck/hunspell/glue/RLBoxHunspell.cpp:59
1 xul.dll mozHunspell::SetDictionary extensions/spellcheck/hunspell/glue/mozHunspell.cpp:189
2 xul.dll mozSpellChecker::SetCurrentDictionary extensions/spellcheck/src/mozSpellChecker.cpp:447
3 xul.dll mozilla::EditorSpellCheck::SetCurrentDictionary editor/spellchecker/EditorSpellCheck.cpp:619
4 xul.dll NS_InvokeByIndex 
5 xul.dll static XPCWrappedNative::CallMethod js/xpconnect/src/XPCWrappedNative.cpp:1130
6 xul.dll XPC_WN_CallMethod js/xpconnect/src/XPCWrappedNativeJSOps.cpp:921
7 xul.dll js::InternalCallOrConstruct js/src/vm/Interpreter.cpp:472
8 xul.dll InternalCall js/src/vm/Interpreter.cpp:532
9 xul.dll Interpret js/src/vm/Interpreter.cpp:3240

bp-17160cdc-1904-4122-8618-5f7cf0220629
bp-d8708309-ce25-4b52-ab39-513490220412

Comment 1

[Makoto Kato [:m_kato]]

I don't know, but this issue occurs on Firefox too. I guess that this issue is spellchecker or RLBox, so moving to Core:spellchecker.

Comment 2

[Wayne Mery (:wsmwk)]

currently far cry from topcrash

Comment 3

[Jens Stutte [:jstutte]]

More than a regression it seems we have something to diagnose?

Comment 4

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1739669

Comment 5

[Bobby Holley (:bholley)]

Seems like we should replace

MOZ_RELEASE_ASSERT(dictSizeResult.isOk());

with

NS_ENSURE_TRUE(dictSizeResult.isOk(), nullptr);

here: https://searchfox.org/mozilla-central/source/extensions/spellcheck/hunspell/glue/RLBoxHunspell.cpp#48

If somebody writes the patch I'll stamp it.

Comment 6

[Jens Stutte [:jstutte]]

Attachment: Bug 1777394 - Do not crash on inaccessible dictionary file. r?bholley

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/139d1aea678b
Do not crash on inaccessible dictionary file. r=bholley

Comment 8

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing build bustage on Unified_cpp_hunspell_glue0.obj. CLOSED TREE
Backout link
Push with failures
Link to failure log 1
Link to failure log 2
Failure line 1:
gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:669: Unified_cpp_hunspell_glue0.obj] Error 1
Failure line 2:
/builds/worker/checkouts/gecko/extensions/spellcheck/hunspell/glue/RLBoxHunspell.cpp:53:31: error: too few arguments provided to function-like macro invocation

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e44cf3339f4b
Do not crash on inaccessible dictionary file. r=bholley

Comment 10

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/e44cf3339f4b

Comment 11

[sfhowes]

Crash in TB 102 with profile not in default location: https://support.mozilla.org/en-US/questions/1394242

Any idea if or when the fix will appear in 102?

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 9292791 [details]
Bug 1777394 - Do not crash on inaccessible dictionary file. r?bholley

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: version 96 regression related to enabling of rlbox sandbox
• User impact if declined: Firefox and Thunderbird crash
• Fix Landed on Version: 106
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): simple improved error check

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Patch applies cleanly.

Comment 14

[Donal Meehan [:dmeehan]]

:wsmwk could we get some verification that this works on the Thunderbird beta/nightly?
Make sure that this is working a expected, then we can uplift

Comment 15

[Wayne Mery (:wsmwk)]

RLBoxHunspell::Create signature does not exist for Thunderbird beta version 106.

However, starting in Thunderbird beta version 106 there are now crashes for rlbox::detail::dynamic_check

bp-a1296693-7918-4b0c-b82a-caeb20221104 for example

Comment 16

[Donal Meehan [:dmeehan]]

Comment on attachment 9292791 [details]
Bug 1777394 - Do not crash on inaccessible dictionary file. r?bholley

Approved for 102.5esr.

Comment 17

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-esr102/rev/75b7e8004645

Comment 18

[Shravan Narayan]

starting in Thunderbird beta version 106 there are now crashes for rlbox::detail::dynamic_check
bp-a1296693-7918-4b0c-b82a-caeb20221104 for example

I have identified the cause for the issue and the fix for this will be tracked in Bug 1742000