1777509 - Add an async version of createContentWindow and use it wherever possible

Status: RESOLVED FIXED

(GeckoView Graveyard :: Sandboxing, task, P3)

Description

[[ex-Mozilla] Agi Sferro | :agi]

The GeckoView implementation of createContentWindow spins the event loop to respond synchronously, but its return value is actually put inside a promise for some callers. We should add an async version of it (e.g. createContentWindowAsync) and call it wherever possible to avoid spinning the event loop unnecessarily.

Comment 1

[Chris Peterson [:cpeterson]]

This problem will be made worse with Fission.

This fix won't require any Fenix changes.

Comment 2

[Chris Peterson [:cpeterson]]

Moving Android Fission bugs to the new GeckoView::Sandboxing component.

Comment 3

[Makoto Kato [:m_kato]]

Attachment: Bug 1777509 - Don't return browsing context directly when creating new window. r=nika!

GeckoView's createContentWindow is implemented by JavaScript and Java. To use
callback, we need to access from JavaScript.

Comment 4

[Makoto Kato [:m_kato]]

Attachment: Bug 1777509 - Part 2. Move event loop from LoadURIDelegate to GeckoViewNavigation. r=#geckoview-reviewers

Depends on D197131

Comment 5

[Makoto Kato [:m_kato]]

Attachment: Bug 1777509 - Part 3. Use browsingContextReadyCallback in createContentWindow. r=#geckoview-reviewers

Depends on D197132

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The following patch is waiting for review from an inactive reviewer:

ID	Title	Author	Reviewer Status
D197131	Bug 1777509 - Part 1. Make nsIBrowsingContextReadyCallback scriptable.	m_kato	nika: Back Jan 2, 2024

:m_kato, could you please find another reviewer?

For more information, please visit BugBot documentation.

Comment 7

[Chris Peterson [:cpeterson]]

(In reply to Chris Peterson [:cpeterson] from comment #1)

This problem will be made worse with Fission.

Agi said Fission will make this problem worse, so I will track this bug for Android Fission.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff4b5833094a
Don't return browsing context directly when creating new window. r=nika,geckoview-reviewers,owlish

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/ff4b5833094a