Closed Bug 1777620 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 34667 - [webcodecs] Add dequeue event to encoder interfaces

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox104 fixed)

Status:
RESOLVED FIXED
Milestone:
104 Branch
Tracking Flags:
Tracking Status
firefox104 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 34667 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/34667
Details from upstream follow.

Chris Cunningham <chcunningham@chromium.org> wrote:

[webcodecs] Add dequeue event to encoder interfaces

Spec for this is still WIP, but lets get it implemented ASAP so folks can test it and verify it meets their needs.

The interesting part of this CL is how events are coalesced to avoid spamming folks. The WPT tests demonstrate this best. The intent is that we should only fire the event 1 time for every batch of decrements to the counter. Here "batch" is defined as any decrements that take place between the user scripts having a chance to run. For ex, if you queue two encodes() and we immediately process those, you will find the encodeQueueSize = 0 when the first dequeue event fires. It would be spammy to fire a second event (one for each of the encodes) since the queue size remains zero.

I plan to specify the above behavior after getting some feedback from owners/partners.

Bug: 1341116

Change-Id: I2672ae96aa03b889821996ee69c2ed427c2a0f81

Reviewed-on: https://chromium-review.googlesource.com/3646113
WPT-Export-Revision: 349daefdb2dfe1ae76991dd9d6b20a1ef40e97dc

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 10 subtests

Status Summary

Firefox

OK : 2
FAIL : 22
ERROR: 1

Chrome

OK : 3
PASS : 34
FAIL : 3

Safari

OK : 2
FAIL : 22
ERROR: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /webcodecs/audio-encoder.https.any.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
    • Simple audio encoding: FAIL (Chrome: PASS, Safari: FAIL)
    • Encode audio with negative timestamp: FAIL (Chrome: PASS, Safari: FAIL)
  • /webcodecs/video-encoder.https.any.worker.html [wpt.fyi]
    • Test VideoEncoder construction: FAIL (Chrome: PASS, Safari: FAIL)
    • Test VideoEncoder.configure(): FAIL (Chrome: PASS, Safari: FAIL)
    • Test successful configure(), encode(), and flush(): FAIL (Chrome: PASS, Safari: FAIL)
    • encodeQueueSize test: FAIL (Chrome: FAIL, Safari: FAIL)
    • Test successful reset() and re-confiugre(): FAIL (Chrome: PASS, Safari: FAIL)
    • Test successful encode() after re-configure().: FAIL (Chrome: PASS, Safari: FAIL)
    • Verify closed VideoEncoder operations: FAIL (Chrome: PASS, Safari: FAIL)
    • Verify unconfigured VideoEncoder operations: FAIL (Chrome: PASS, Safari: FAIL)
    • Verify encoding closed frames throws.: FAIL (Chrome: PASS, Safari: FAIL)
    • Encode video with negative timestamp: FAIL (Chrome: PASS, Safari: FAIL)
  • /webcodecs/video-encoder.https.any.html [wpt.fyi]
    • Test VideoEncoder construction: FAIL (Chrome: PASS, Safari: FAIL)
    • Test VideoEncoder.configure(): FAIL (Chrome: PASS, Safari: FAIL)
    • Test successful configure(), encode(), and flush(): FAIL (Chrome: PASS, Safari: FAIL)
    • encodeQueueSize test: FAIL (Chrome: FAIL, Safari: FAIL)
    • Test successful reset() and re-confiugre(): FAIL (Chrome: PASS, Safari: FAIL)
    • Test successful encode() after re-configure().: FAIL (Chrome: PASS, Safari: FAIL)
    • Verify closed VideoEncoder operations: FAIL (Chrome: PASS, Safari: FAIL)
    • Verify unconfigured VideoEncoder operations: FAIL (Chrome: PASS, Safari: FAIL)
    • Verify encoding closed frames throws.: FAIL (Chrome: PASS, Safari: FAIL)
    • Encode video with negative timestamp: FAIL (Chrome: PASS, Safari: FAIL)
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/558dc8ced439
[wpt PR 34667] - [webcodecs] Add dequeue event to encoder interfaces, a=testonly

https://hg.mozilla.org/mozilla-central/rev/558dc8ced439

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox104: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
You need to log in before you can comment on or make changes to this bug.