1777824 - Exporting 102 profile with address book and importing address books only into 102 fails in weird ways

Status: RESOLVED FIXED

(MailNews Core :: Import, defect, P2)

Description

[Thomas D. (:thomas8)]

Seen on 102.0 and 104.0a1 (2022-07-02) (64-bit)

STR

Caveat: You need a new test install of 102 for this to avoid dataloss because we want to delete your entire AB later for clarity of testing.

1. In completely empty AB, create some sample contacts which you'll recognize throughout the process.
2. Tools > Export to export entire profile from 102 to a zip file (make a note where you save it)
3. On your test install (do not use real data here!), delete all contacts from all address books (you may meet Bug 1777808 on the way).
4. Tools > Import > Import from another TB install, Continue
5. From step 2 of import tool, select "Choose a Zip file", Continue
6. Select profile backup zip file exported above, click "Open"
7. Step 3 of Import tool, uncheck Accounts, Calenders, Mail messages to remain with only Address books checked, Continue.
8. Step 4 (confirm): Data to be imported: Address Books (only), Start Import!
9. Click Finish which will restart TB.

Actual

• It imported some stale AB data from previous testing
• It did not import the contacts created and present before the Export.
• I also believe I had an import which did nothing.

Expected

• don't import random stale data (maybe that went wrong on the export already? but how?)
• export - delete - import ABs from profile should restore the original data of the AB only

Saw one possible related error:
about:addressbook : Unable to run script because scripts are blocked internally. 30

Comment 1

[Ping Chen [:rnons] (away)]

Seems we need to close all address books before exporting, because newly created contacts were not written into .sqlite files yet.

Comment 2

[Ping Chen [:rnons] (away)]

Attachment: Bug 1777824 - Copy .sqlite-wal files when importing address books from TB profile. r=freaktechnik

When exporting profile, edits to address books may still be in .sqlite-wal. Copy .sqlite-wal files back when importing to restore the edits.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3cbd7d7cabf0
Copy .sqlite-wal files when importing address books from TB profile. r=freaktechnik

Comment 4

[Ping Chen [:rnons] (away)]

Comment on attachment 9284089 [details]
Bug 1777824 - Copy .sqlite-wal files when importing address books from TB profile. r=freaktechnik

[Approval Request Comment]
Regression caused by (bug #): bug 1720042
User impact if declined: Address book cards in sqlite are not fully imported
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): low

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9284089 [details]
Bug 1777824 - Copy .sqlite-wal files when importing address books from TB profile. r=freaktechnik

[Triage Comment]
Approved for beta

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 103.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/518d5d0ecff9

Comment 7

[Ping Chen [:rnons] (away)]

Comment on attachment 9284089 [details]
Bug 1777824 - Copy .sqlite-wal files when importing address books from TB profile. r=freaktechnik

[Approval Request Comment]
Regression caused by (bug #): bug 1720042
User impact if declined: Address book cards in sqlite are not fully imported
Testing completed (on c-c, etc.): beta
Risk to taking this patch (and alternatives if risky): low

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9284089 [details]
Bug 1777824 - Copy .sqlite-wal files when importing address books from TB profile. r=freaktechnik

[Triage Comment]
Approved for esr102

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 102.0.3:
https://hg.mozilla.org/releases/comm-esr102/rev/40e4646d7320