Closed Bug 1777829 Opened 1 month ago Closed 1 month ago

stub-generator-helpers.js should pass typed array to IOUtils.write

Categories

(DevTools :: General, defect)

Product:
DevTools
Component:
General
Type:
defect

Tracking

(firefox104 fixed)

Status:
RESOLVED FIXED
Milestone:
104 Branch
Tracking Flags:
Tracking Status
firefox104 --- fixed

People

(Reporter: arai, Assigned: arai)

References

Details

Attachments

(1 file)

Bug 1777829 - Fix DevTools stub generator. r?#devtools-reviewers!
48 bytes, text/x-phabricator-request
Details | Review

https://searchfox.org/mozilla-central/rev/da3cc1b31be7a7d919d6ebde4e3c033a83446e05/devtools/client/webconsole/test/browser/stub-generator-helpers.js#260,303-305

  const fileContent = `/* Any copyright is dedicated to the Public Domain.
...
`;

  await IOUtils.write(filePath, fileContent);

  FAIL Uncaught exception in test - at chrome://mochitests/content/browser/devtools/client/webconsole/test/browser/stub-generator-helpers.js:305 - TypeError: IOUtils.write: Argument 2 is not an object.

it should be await IOUtils.write(filePath, new TextEncoder().encode(fileContent));

Blocks: 1667455
Attachment #9283899 - Attachment description: Bug 1777829 - Fix stub generator. r?#devtools-reviewers! → Bug 1777829 - Fix DevTools stub generator. r?#devtools-reviewers!

https://hg.mozilla.org/mozilla-central/rev/bc16e1023d45

Status: ASSIGNED → RESOLVED
Closed: 1 month ago
status-firefox104: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
You need to log in before you can comment on or make changes to this bug.