1777870 - URLBar loses formatting when dragging out an empty new tab to a separate window

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[findroot_cornflower]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0

Steps to reproduce:

1. Create a new tab.
2. Drag a new tab or an existing one out of the main window.
3. Greyed out parts of the URL become white like the domain name. (i.e. Youtube, Spotify etc.)

Actual results:

Greyed out parts of the URL became white like the domain name.

i.e. If I have YouTube in 1 tab, the URL is: https://youtube.com. And the "https://" is greyed out while "youtube" is white.

And when I create a new tab and seperate it from the YouTube tab - the URL in the original YouTube tab becomes all white.

And when I drag an existing tab out of the main window to a seperate one - the URL in that dragged out tab becomes all white.

Expected results:

When creating a new tab and seperating it from the YouTube tab - the URL in the original YouTube tab should stay with some parts greyed out.

When dragging an existing tab out of the main window to a seperate one - the URL in that dragged out tab should stay with some parts greyed out.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Address Bar' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Marco Bonardo [:mak]]

Ah I can reproduce this bug, and it's not good.

I think it's a regression and I'm looking for a range.

Comment 3

[Marco Bonardo [:mak]]

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=207e539276f34033a44ee17821e2c1aaaf6580a1&tochange=c6bad895109788e0acdb6d619ce79cd9553424de

So it's very likely Bug 1681712.
It sounds like we're missing a call to a .formatValue() or we have a new call setting the urlbar value.
Neil any idea off-hand that may help saving time before we debug it further?

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1681712

Comment 5

[Neil Deakin]

I don't know much about the url bar handling, but calls to formatValue to happen when the url field is focused, blurred, the url value is changed and the page security status changed. I don't think any of those happen when the tab is dragged out.

You could always call formatValue at the end of swapBrowsersAndCloseOther I think.

Comment 6

[Dianna Smith [:diannaS]]

:mak is comment 5 enough for you to take a look at this? If so, wondering what fx train we want to target?

Comment 7

[Marco Bonardo [:mak]]

(In reply to Dianna Smith [:diannaS] from comment #6)

:mak is comment 5 enough for you to take a look at this? If so, wondering what fx train we want to target?

Yes, the bug is actionable, in the sense we must debug why it happens and provide a fix.
I think it's worth investigating it sooner than later because we care about formatting, but it happens in a specific case, has a workaround (just switch tabs), thus we don't have a specific target version..

Comment 8

[:Gijs (he/him)]

I believe bug 1718082 has fixed this on current nightly. Could someone doublecheck?

Comment 9

[Marco Bonardo [:mak]]

I can still reproduce the bug, though it's intermittent.

Comment 11

[Dão Gottwald [:dao]]

Attachment: Bug 1777870 - Format the urlbar value after tab select and focus change, and avoid formatting multiple times when handling blur events. r=jteow

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb27ab3b0efd
Format the urlbar value after tab select and focus change, and avoid formatting multiple times when handling blur events. r=jteow

Comment 13

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/fb27ab3b0efd

Comment 14

[Cristian Baica [:cbaica], Release Desktop QA]

I've managed to reproduce the issue using Fx 115.0 beta.
The issue is verified fixed using the latest Fx119.0a1, Fx118.0b2 and Fx117.0RC on Windows 10 and Ubuntu 20.04. When a tab is dragged to a new window, the URL formatting no longer changes. Same part remains highlighted before & after the tab move.