1777910 - *** MESA_GLSL_CACHE_DISABLE is deprecated; use MESA_SHADER_CACHE_DISABLE instead ***

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Ludovic Hirlimann [:Usul]]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:104.0) Gecko/20100101 Firefox/104.0

Steps to reproduce:

Launch nigthly from the command line.

Actual results:

This message is printed :
*** MESA_GLSL_CACHE_DISABLE is deprecated; use MESA_SHADER_CACHE_DISABLE instead ***

Which could come from two places according to searchfox :
https://searchfox.org/mozilla-central/search?q=MESA_GLSL_CACHE_DISABLE&path=

Expected results:

Firefox uses the proper env variable and no message is printed.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Darkspirit]

MESA_SHADER_CACHE_DISABLE only exists since Mesa 22.1.0:
https://github.com/mesa3d/mesa/commit/54d0a2cfad3352750dedf4851a6f097c5e507c3d
The older env var is required to avoid an RDD process sandbox crash even with Mesa versions before 22.1.0.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

:jld, since you are the author of the regressor, bug 1769182, could you take a look?
For more information, please visit auto_nag documentation.

Comment 4

[Gian-Carlo Pascutto [:gcp]]

I guess we either probe the Mesa version and set it depending on that, or we could even set both (if probing the Mesa version is problematic). From reading the code that would make the warning go away.

Comment 5

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Attachment: Bug 1777910 - Adjust Mesa environment variables for change/deprecation in 22.1.

Mesa 22.1.0 changed the env var name MESA_GLSL_CACHE_DISABLE to
MESA_SHADER_CACHE_DISABLE; it still accepts the old name, but prints a
deprecation warning. If we set both env vars, then we can support both
old and new Mesas correctly (the warning won't be printed if the new env
var is also set).

Comment 6

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

At the moment I don't have a Linux install with a new enough Mesa to test this, but here's a Try run with some builds if anyone wants to.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3bfb4a4cbf1b
Adjust Mesa environment variables for change/deprecation in 22.1. r=gcp

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/3bfb4a4cbf1b

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for ESR102 approval when you get a chance.

Comment 10

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

VA-API was enabled in 103 and is still Nightly-only; this could still affect ESR102 if someone flips the pref in about:config, but also, the impact is currently just a cosmetic warning message. Given all of that, I don't know if it's worth uplifting.