1778086 - Input type date with min max set opens datepicker at current month, if min max in current year.

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[matrim20]

Attachment: Datepicker UI.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0

Steps to reproduce:

Opens always in current month:
<input type="date" min="2022-04-05" max="2022-04-08">
Opens in corrent month:
<input type="date" min="2021-04-05" max="2021-04-08">

Tested on date 2022-07-05.

Presumed reason: If intended year equals current year, the datepicker UI always uses the current month, instead of the intended month.

Actual results:

First line opens the datepicker displaying July 2022.
Second line opens the datepicker displaying April 2021.

Attached screenshot displays the current state.

Expected results:

First line opens the datepicker displaying April 2022.
Second line opens the datepicker displaying April 2021.

(In comparison: Chrome 103 opens both in the correct month)

Comment 1

[Ina Popescu, Desktop QA]

I've managed to reproduce this issue on the latest versions Nightly 105.0a1 and Firefox 103.0.1 on Windows 10 x64.
Setting this to NEW. If this is not the correct component, please feel free to change it to a more appropriate one.

Narrowed down the regression range to:

Last good revision: bfbef2b417a1bfd26a4ce3b5d1f062d8266edb91
First bad revision: 8262d23cdf85c12d77ab69eaf56feba6c76c36d8
Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=bfbef2b417a1bfd26a4ce3b5d1f062d8266edb91&tochange=8262d23cdf85c12d77ab69eaf56feba6c76c36d8

Comment 2

[Hsin-Yi Tsai (she/her)[:hsinyi]]

https://searchfox.org/mozilla-central/source/toolkit/content/widgets/datekeeper.js#107 doesn't look right to me.
Maybe we should just change the line to
selectedMonth = Math.min(Math.max(month, minMonth), maxMonth);

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1728366

Comment 4

[Pascal Chevrel:pascalc]

(In reply to Hsin-Yi Tsai (she/her) [:hsinyi] from comment #2)

https://searchfox.org/mozilla-central/source/toolkit/content/widgets/datekeeper.js#107 doesn't look right to me.
Maybe we should just change the line to
selectedMonth = Math.min(Math.max(month, minMonth), maxMonth);

Mark, it seems that we have a clue about the root of the problem, could you help find an owner? Thanks

Comment 5

[Mark Striemer [:mstriemer]]

Attachment: Bug 1778086 - Default to valid month in datepicker with current year range r?mconley

Comment 6

[Mark Striemer [:mstriemer]]

Thanks Hsin-Yi, that worked well!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe7c0cde6cb6
Default to valid month in datepicker with current year range r=mconley

Comment 8

[Marian-Vasile Laza]

Backed out changeset fe7c0cde6cb6 (Bug 1778086) for causing bc failures on browser_datetime_datepicker.js.
Backout link
Push with failures <--> bc3
Failure Log

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:mstriemer, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 10

[Mike Conley (:mconley) (:⚙️)]

Clearing review request - I suspect mstriemer will get to this when he gets to this.

Comment 11

[josh.griff00]

Someone should fix this... it's annoying to have to make hack-y workarround to solve this problem. This issue does not occur on any of the other major browsers.

Comment 13

[Jonathan Kew [:jfkthame]]

:mstriemer, I ran across this and have taken the liberty of stealing your patch and (I hope) fixing up the issue that resulted in test failures last time (comment 8). I'll post the updated version for your review.

Comment 14

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1778086 - Default to valid month in datepicker with current year range. r=mstriemer

(Updated version of mstriemer's patch in D159725.)

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/956988c98ea6
Default to valid month in datepicker with current year range. r=mstriemer,reusable-components-reviewers,emilio

Comment 16

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/956988c98ea6