Closed
Bug 1778106
Opened 4 years ago
Closed 2 years ago
Move Pocket code to use mjs files, rather than defining sourceType for ESLint
Categories
(Firefox :: Pocket, task)
Firefox
Pocket
Tracking
()
RESOLVED
FIXED
124 Branch
| Tracking | Status | |
|---|---|---|
| firefox124 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
(Blocks 1 open bug)
Details
Attachments
(1 external file)
With the transition to using ES modules rather than JSMs getting started, we are now using the .mjs extension for those files.
We'd like to transition our content code that is using modules to use the .mjs extension as well - the primary gains of this are that we a) don't need to manually specify sourceType: module for ESLint, b) this gives a visual distinction to developers that the file is a module rather than a regular JavaScript file.
This bug is for the pocket files.
| Assignee | ||
Comment 1•2 years ago
|
||
Updated•2 years ago
|
Assignee: nobody → standard8
Status: NEW → ASSIGNED
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6ce209a21e39
Move Pocket code to use mjs files, rather than defining sourceType for ESLint. r=thecount
Comment 3•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox124:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 124 Branch
Comment 4•2 years ago
|
||
:standard8 could this be affecting some Pocket tests on Android CI?
Flags: needinfo?(standard8)
| Assignee | ||
Comment 5•2 years ago
|
||
I think it is unlikely, as this code is in browser/ which should be Firefox desktop specific, and I can't see any obvious references to it in the Android repositories.
Flags: needinfo?(standard8)
You need to log in
before you can comment on or make changes to this bug.
Description
•