1778139 - Quickactions flash when typing in the urlbar

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Dale Harvey (:daleharvey)]

Typing in the urlbar causes QuickActions to flash, this is due to them using getViewUpdate and that they are invalidated and redrawn on every urlbar update.

One option would be to have getViewUpdate return some type of hash that indicates the number of results returned, if we have the same number of results on subsequent updates then we do not need to create a fresh dom, only update its contents. The issue with this is the results will still flash when we have different number of results.

Another option would be to have QuickActions return plain UrlbarResults, make sure they are grouped together and update the styling to make a column layout. I think this constrains some layout issues we dealt with in FlowState that arent relevant for Desktop at the moment.

Comment 1

[Dale Harvey (:daleharvey)]

Just to update, when I say a plain UrlbarResult, an initial guess seems like the best option would be to create a new RESULT_TYPE.ACTION and return one result for each action.

Comment 2

[Dale Harvey (:daleharvey)]

Attachment: WIP: Bug 1778139 - Prevent quickactions from flashing while typing. f=adw

Comment 3

[Dale Harvey (:daleharvey)]

Attachment: Bug 1778139 - Cache QuickActions strings to avoid UI flashing. r=adw

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/63fff3004d83
Cache QuickActions strings to avoid UI flashing. r=adw

Comment 5

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/63fff3004d83

Comment 6

[Cristian Baica [:cbaica], Release Desktop QA]

The issue is verified fixed using the latest Fx104.0a1 on Windows 10, Ubuntu 20.04 and macOS. The QuickActions buttons no longer flick when typing or opening the URL bar dropdown.