Closed Bug 1778149 Opened 2 years ago Closed 2 years ago

13.87 - 5.16% perf_reftest_singletons id-getter-2.html / perf_reftest_singletons coalesce-1.html + 4 more (Linux, Windows) regression on Tue June 28 2022

Categories

(Core :: DOM: Core & HTML, defect)

defect

Tracking

()

RESOLVED WONTFIX
Tracking Status
firefox-esr91 --- unaffected
firefox-esr102 --- unaffected
firefox102 --- unaffected
firefox103 --- unaffected
firefox104 --- affected

People

(Reporter: aglavic, Unassigned)

References

(Regression)

Details

(4 keywords)

Perfherder has detected a talos performance regression from push d984d643826973bc153e52834b918d88c2c39db5. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio Test Platform Options Absolute values (old vs new)
282% perf_reftest display-none-1.html linux1804-64-shippable-qr e10s fission stylo webrender-sw 0.02 -> 0.07
233% perf_reftest display-none-1.html linux1804-64-shippable-qr e10s fission stylo webrender 0.02 -> 0.05
14% perf_reftest_singletons id-getter-2.html windows10-64-shippable-qr e10s fission stylo webrender 544.14 -> 619.59
13% perf_reftest coalesce-1.html linux1804-64-shippable-qr e10s fission stylo webrender 70.35 -> 79.78
12% perf_reftest coalesce-1.html windows10-64-shippable-qr e10s fission stylo webrender 64.22 -> 72.04
11% perf_reftest coalesce-1.html linux1804-64-shippable-qr e10s fission stylo webrender-sw 70.97 -> 78.98
11% perf_reftest coalesce-1.html windows10-64-shippable-qr e10s fission stylo webrender-sw 63.31 -> 69.97
5% perf_reftest_singletons coalesce-1.html linux1804-64-shippable-qr e10s fission stylo webrender 175.84 -> 184.90

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
8% perf_reftest_singletons getElementById-1.html macosx1015-64-shippable-qr e10s fission stylo webrender 53.11 -> 48.96

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

For more information on performance sheriffing please see our FAQ.

Flags: needinfo?(jcoppeard)

Set release status flags based on info from the regressing bug 1352532

These changes are because DOM nodes are being finalized as part of a minor GC which is happening during the test, whereas previously they were finalized as part of a major GC which ran after the the test was complete. So it's now counting this as part of the test time whereas previously it didn't.

This does not represent a change in performance. Therefore we should accept this regression.

Status: NEW → RESOLVED
Closed: 2 years ago
Flags: needinfo?(jcoppeard)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.