1778158 - quartz: Avoid reading beyond the end of image surfaces.

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

The last row of data may have less than stride bytes so make sure we
only copy what we need.

This corresponds to cairo:cccc81ccba99600483621e02ae9438a4a5a3d024

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1778158 - quartz: Avoid reading beyond the end of image surfaces.

The last row of data may have less than stride bytes so make sure we
only copy what we need.

This corresponds to cairo:cccc81ccba99600483621e02ae9438a4a5a3d024

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/021f32254c01
quartz: Avoid reading beyond the end of image surfaces. r=jfkthame

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/021f32254c01

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 9284192 [details]
Bug 1778158 - quartz: Avoid reading beyond the end of image surfaces.

Beta/Release Uplift Approval Request

• User impact if declined: Fixes crashes that will be exposed by bug 1769429 otherwise sometimes printing will be broken
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This just ensures that we only copy the data that we need.
• String changes made/needed:
• Is Android affected?: Yes

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: This will let us land a fix for bug 1769429
• User impact if declined: Sometimes printing will be broken
• Fix Landed on Version: 104
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky):

Comment 5

[Donal Meehan [:dmeehan]]

Comment on attachment 9284192 [details]
Bug 1778158 - quartz: Avoid reading beyond the end of image surfaces.

Approved for 103.0b9, thanks.

Comment 6

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0e614c093700

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9284192 [details]
Bug 1778158 - quartz: Avoid reading beyond the end of image surfaces.

Looks like this was effective at preventing the crashes from bug 1719215 from returning afer bug 1769429 was landed. Approved for 102.2esr.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr102/rev/6f460b86ffd3