1778182 - put private browsing taskbar pinning & window separation behind a distinct pref

Status: RESOLVED FIXED

(Firefox :: Shell Integration, enhancement, P2)

Description

[[e-mail] (:bhearsum)]

I originally put this behind browser.privacySegementation.enabled because it seemed harmless to do so. More recently, we've decided to run an experiment for these features, which means we must enable this pref for targetted users. This pref also will track who opts into privacy segementation features in 106 and later - so there's some risk that we may opt people in the experiment into that, which is not desired.

Using a unique pref for the taskbar pinning & window separation will alleviate this. This will be short lived, as these things will no longer be pref'ed off beginning with 106.

Comment 1

[[e-mail] (:bhearsum)]

Attachment: Bug 1778182: put private browsing taskbar pinning & window separation behind a distinct pref r?nalexander!

browser.privacySegmentation.enabled is going to be set when users opt into Felt Privacy. When I originally wrote some of this code I naively used it to pref things on, on the assumption that there would never be a situation where it would be true before 106 (when we remove the pref-off for this work).

However, we want to run an experiment with pinning private browsing to the taskbar ahead of 106. To avoid any possibility of accidentally opting users into Felt Privacy without their consent, let's use a distinct pref for turning these features off for now. This pref will disappear in the 106 cycle, as none of this code needs to be behind one at that point - so I don't think this needs to go in firefox.js.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e00db0440f3
put private browsing taskbar pinning & window separation behind a distinct pref r=nalexander

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/8e00db0440f3

Comment 4

[Punam Dahiya [:pdahiya]]

Thanks @bhearsum for the the patch. On about:privatebrowsing, click of PinToTaskbar button (see attached screenshot) will invoke synchronously

a) set pref 'browser.privacySegmentation.windowSeparation.enabled' to true
b) Call PinToTaskbar(true) method of ShellService API.

https://searchfox.org/mozilla-central/rev/f816e52d85cdaf0be7c9e1d2297f833e9ef53e2e/toolkit/components/messaging-system/lib/SpecialMessageActions.jsm#92

Does that sequence looks good or pref need to be set to true at an earlier point (say on browser startup) in Firefox lifecycle for Private Pinning to work.

Comment 5

[Punam Dahiya [:pdahiya]]

Attachment: Pin Private Tab

Comment 6

[[e-mail] (:bhearsum)]

(In reply to Punam Dahiya [:pdahiya] from comment #4)

Thanks @bhearsum for the the patch. On about:privatebrowsing, click of PinToTaskbar button (see attached screenshot) will invoke synchronously

a) set pref 'browser.privacySegmentation.windowSeparation.enabled' to true
b) Call PinToTaskbar(true) method of ShellService API.

https://searchfox.org/mozilla-central/rev/f816e52d85cdaf0be7c9e1d2297f833e9ef53e2e/toolkit/components/messaging-system/lib/SpecialMessageActions.jsm#92

Does that sequence looks good or pref need to be set to true at an earlier point (say on browser startup) in Firefox lifecycle for Private Pinning to work.

That should be just fine. pinToTaskbar(true) will work even if the pref is false (we just don't want to expose that without that pref being set to true for now).