1778281 - Context menu in browser toolbox's style editor is light despite dark theme

Status: VERIFIED FIXED

(DevTools :: Style Editor, defect, P3)

Description

[bloonyapprentice]

Attachment: Current.png

Steps to Reproduce

1. Enable Dark theme in about:addons
2. Enable Browser Toolbox
3. Open Browser Toolbox and go to the "Style Editor" tab
4. Right-click to show the context menu

Actual results

The context menu is light, disregarding the user's theme.

Expected results

The context menu should be dark, following the user's theme.

Regression range

Mozregression points to Bug 1738380

 4:36.65 INFO: Narrowed integration regression window from [51a3fc9e, f0c4c97a] (3 builds) to [0d8f25c4, f0c4c97a] (2 builds) (~1 steps left)
 4:36.65 INFO: No more integration revisions, bisection finished.
 4:36.65 INFO: Last good revision: 0d8f25c4388af0894425506e71024044f4d3402a
 4:36.65 INFO: First bad revision: f0c4c97a8e6aa34214f287cb499321b6a0186c2f
 4:36.65 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0d8f25c4388af0894425506e71024044f4d3402a&tochange=f0c4c97a8e6aa34214f287cb499321b6a0186c2f

Comment 1

[bloonyapprentice]

Attachment: Before.png

This is how it looks before, taken on v101.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1738380

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1738380, could you take a look?
For more information, please visit auto_nag documentation.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The bug has a release status flag that shows some version of Firefox is affected, thus it will be considered confirmed.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1778281 - Don't override effective color-scheme if there's no theme. r=bomsy,jdescottes

In the browser toolbox window, we include common.css, but we don't
apply the theme-dark/theme-light classes, so we end up overriding the
color-scheme to light.

Instead, only override color-scheme for theme-light/theme-dark, so that
context menus and so have the right appearance.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d564e806c7d1
Don't override effective color-scheme if there's no theme. r=jdescottes

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/d564e806c7d1

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox103 to wontfix.

For more information, please visit auto_nag documentation.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9284332 [details]
Bug 1778281 - Don't override effective color-scheme if there's no theme. r=bomsy,jdescottes

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial CSS change.
• String changes made/needed: none
• Is Android affected?: No

Comment 10

[Donal Meehan [:dmeehan]]

Comment on attachment 9284332 [details]
Bug 1778281 - Don't override effective color-scheme if there's no theme. r=bomsy,jdescottes

Approved for 103.0b7, thanks.

Comment 11

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/36ab1885ee35

Comment 12

[Monica Chiorean]

I was able to reproduce the issue on Win10 using build 103.0a1 (20220606212503).
Verified as fixed on Win10/Ubuntu20.4 using Beta 103.0b7 (20220710185935) and Nightly 104.0a1 (20220712093327).

Issue is still reproducing on Mac10.13 using both Beta 103.0b7 and Nightly 104.0a1 (20220712093327). Was the fix for Mac also included, or should we log a separate issue? (see attached screenshot). Thank you.

Comment 13

[Monica Chiorean]

Attachment: Mac screenshot

Comment 14

[Emilio Cobos Álvarez (:emilio)]

Mac 10.13 doesn't have dark mode support at the OS level so it's expected.

Comment 15

[Monica Chiorean]

Marking issue as verified based on above comment.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for ESR102 approval when you get a chance.

Comment 17

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9284332 [details]
Bug 1778281 - Don't override effective color-scheme if there's no theme. r=bomsy,jdescottes

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Not sure it's worth it since it's mostly cosmetic and affects only devtools, but it's also harmless and fixes a 102 regression, technically.
• User impact if declined: devtools cosmetic fix.
• Fix Landed on Version: 104
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial CSS fix up.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9284332 [details]
Bug 1778281 - Don't override effective color-scheme if there's no theme. r=bomsy,jdescottes

Trivial fix, approved for 102.2esr.

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr102/rev/8fcaf53d6b89

Comment 20

[Monica Chiorean]

Verified as fixed on Win10/Ubuntu 20.4 using build from treeherder 102.2.0esr(20220809193701).