1778318 - Remove JS getters from internal module objects

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Jon Coppeard (:jonco)]

Following bug 1774454, the JS getters on internal module objects are only used by test code, via the shell module object wrapper system. None of these objects are exposed to JS.

If change the shell module object wrappers to use the C++ accessors we can remove these getters entirely.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1778318 - Part 1: Use C++ accessors of internal module objects in shell object wrappers r?arai

Test code interacts with these module objects by means of the shell object
wrappers. If we add a few more C++ accessors where necessary we can use these
instead of calling the JS property getters.

Comment 2

[Jon Coppeard (:jonco)]

Attachment: Bug 1778318 - Part 2: Remove getters from internal module objects r?arai

Since these getters are now unused we can remove them.

Depends on D151133

Comment 3

[Jon Coppeard (:jonco)]

Attachment: Bug 1778318 - Part 3: Remove prototypes for internal module objects r?arai

Since these no longer have any methods or getters we can give them null prototypes.

Depends on D151134

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/071ec66b1874
Part 1: Use C++ accessors of internal module objects in shell object wrappers r=arai
https://hg.mozilla.org/integration/autoland/rev/f2acb176f0ff
Part 2: Remove getters from internal module objects r=arai
https://hg.mozilla.org/integration/autoland/rev/4381d9d2dce1
Part 3: Remove prototypes for internal module objects r=arai

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/071ec66b1874
https://hg.mozilla.org/mozilla-central/rev/f2acb176f0ff
https://hg.mozilla.org/mozilla-central/rev/4381d9d2dce1