1778335 - Typing https://mozilla.org/ into address bar suggests "httphttps://mozilla.org/ — Visit" (additional http prefix)

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Kestrel]

Attachment: First suggestion has additional http prefix

STR:

1. Type https://mozilla.org/ into the address bar, including the trailing slash (site needs to autofill and have a www subdomain).

Expected:
First suggested item is https://mozilla.org/ — Visit or https://www.mozilla.org/ — Visit.

Actual:
After typing the trailing slash, the first suggestion becomes httphttps://mozilla.org/ — Visit, having an additional http prefix. Pressing Enter does a web search or tries to open the httphttps: protocol.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=7769fe500298f839594d1c1a3782ad23b5d5926e&tochange=58d8e3010b7739779b9651e8c213c5865601b49a

Regressed by Bug 1770095.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:daisuke, since you are the author of the regressor, bug 1770095, could you take a look?
For more information, please visit auto_nag documentation.

Comment 2

[Daisuke Akatsuka (:daisuke)]

Hi Kestrel! Thank you very much for the report.

Yes, I also could reproduce this issue.
I will fix it.
Thanks again.

Comment 3

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1778335: Handle a URL that has www name in history correctly.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b35262d256b9
Handle a URL that has www name in history correctly. r=adw

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/b35262d256b9

Comment 6

[Daisuke Akatsuka (:daisuke)]

Comment on attachment 9284426 [details]
Bug 1778335: Handle a URL that has www name in history correctly.

Beta/Release Uplift Approval Request

• User impact if declined: There is a case where displaying autofill is wrong.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The change is only a few rows and affects only autofill feature.
• String changes made/needed: None
• Is Android affected?: Unknown

Comment 7

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/798b8c89f9ff

Comment 8

[Donal Meehan [:dmeehan]]

Comment on attachment 9284426 [details]
Bug 1778335: Handle a URL that has www name in history correctly.

Approved for 103.0b7, thanks.

Comment 9

[Monica Chiorean]

Reproduced the issue on Win10 using build 103.0a1(20220607214725).
Verified as fixed on Beta 103.0b7(20220710185935) and Nightly 104.0a1(20220711094852).