1778717 - Save to Pocket panel refresh recent saves edge cases

Status: VERIFIED FIXED

(Firefox :: Pocket, defect)

Description

[Scott [:thecount] Downe]

I noticed that if you save something like https://developer.mozilla.org/en-US/docs/Web/CSS/box-shadow recently, and try to open the home panel, it doesn't open the home panel.

This is due to the article having some props we didn't expect, and in a format that we didn't expect.

I think easily fixable, but I also think we should take this time to safeguard this so if another story has an unexpected format to the data, we can handle it gracefully.

Comment 1

[Scott [:thecount] Downe]

Attachment: Bug 1778717 - Pocket panel refresh fixing article view for sparse stories

Comment 2

[Scott [:thecount] Downe]

To test:

1. Save links with very little usable Pocket data, example these three:
   https://developer.mozilla.org/en-US/docs/Web/CSS/box-shadow
   https://searchfox.org/mozilla-central/source/browser/components/pocket/content/panels/js/components/ArticleList/ArticleList.jsx
   https://bugzilla.mozilla.org/show_bug.cgi?id=1746013
2. open a newtab
3. Open the Pocket panel

Expected: should see the above 3 pages as recent saves, and the panel should be displaying best it can with the data it has.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/07d175801edc
Pocket panel refresh fixing article view for sparse stories r=gvn

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/07d175801edc

Comment 5

[Scott [:thecount] Downe]

[Tracking Requested - why for this release]: It is impacting users opening the Pocket home panel if they saved a story recently that doesn't have common metadata. It's kinda an edge case, but worth fixing, and we don't really know how many people it is impacting. When it happens, the panel just doesn't load until that story that's causing the issue is no longer a recent save.

Comment 6

[Donal Meehan [:dmeehan]]

Tracking request accepted.
:thecount could you please submit a beta uplift request if you're confident in the fix in Nightly? (The last 103 beta build is this week, 2022-07-14)

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:thecount, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox103 to wontfix.

For more information, please visit auto_nag documentation.

Comment 8

[Scott [:thecount] Downe]

Comment on attachment 9284716 [details]
Bug 1778717 - Pocket panel refresh fixing article view for sparse stories

Beta/Release Uplift Approval Request

• User impact if declined: Pocket home panel is not displayed for users when it should in certain cases.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: To test:

1. Save links with very little usable Pocket data, example these three:
   https://developer.mozilla.org/en-US/docs/Web/CSS/box-shadow
   https://searchfox.org/mozilla-central/source/browser/components/pocket/content/panels/js/components/ArticleList/ArticleList.jsx
   https://bugzilla.mozilla.org/show_bug.cgi?id=1746013
2. open a newtab
3. Open the Pocket panel

Expected: should see the above 3 pages as recent saves, and the panel should be displaying best it can with the data it has.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just a couple lines of code that just sets fallback props..
• String changes made/needed: None
• Is Android affected?: No

Comment 9

[Donal Meehan [:dmeehan]]

Comment on attachment 9284716 [details]
Bug 1778717 - Pocket panel refresh fixing article view for sparse stories

Approved for 103.0b8, thanks.

Comment 10

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a6f86ef73464

Comment 11

[Anca Soncutean, Desktop QA]

Reproduced with Fx 104.0a1 (2022-07-08) on Windows 10.
Verified fixed with Fx 104.0a1 (2022-07-13) and Fx 103.0b8 on Windows 10, macOS 11 and Ubuntu 20.04.