Allow users to pass appId as an argument in iOS and Android
Categories
(Data Platform and Tools :: Glean: SDK, task, P4)
Tracking
(Not tracked)
People
(Reporter: brizental, Unassigned)
References
Details
(Whiteboard: [telemetry:glean-sdk:m?])
The appId in these platforms is currently inferred from the application context.
I was wondering if it would be possible to make it an option for users to actually pass that as an argument to Glean.initialiaze and overwrite the default value.
The use case here is the Mozilla VPN app, which is using the Glean Android SDK in Android and Glean.js everywhere else (and is planning to soon use the iOS SDK in iOS). Because of this caveat from the Android SDK, this means the data for Android specifically is landing in a separate table. Would be nice if it just went to the same tables.
See also, [:sarahbird]s comment on Slack: https://mozilla.slack.com/archives/C018SNLQP6C/p1657208456217729
|
Reporter | |
Updated•4 years ago
|
|
||
Comment 1•4 years ago
|
||
(In reply to Beatriz Rizental [:brizental] from comment #0)
The appId in these platforms is currently inferred from the application context.
I was wondering if it would be possible to make it an option for users to actually pass that as an argument to Glean.initialiaze and overwrite the default value.
That would require some serious considerations on our end, since the auto discovery of the app id solves quite a few problems and provides us with some guarantees we wouldn't otherwise have.
The use case here is the Mozilla VPN app, which is using the Glean Android SDK in Android and Glean.js everywhere else (and is planning to soon use the iOS SDK in iOS). Because of this caveat from the Android SDK, this means the data for Android specifically is landing in a separate table. Would be nice if it just went to the same tables.
This can still be achieved using product views in the pipeline. I believe this can be signaled with something like this change, but we need to double check with pipeline folks. Worst case, I believe we can create a custom view manually.
See also, [:sarahbird]s comment on Slack: https://mozilla.slack.com/archives/C018SNLQP6C/p1657208456217729
Unfortunately I can't seem to be able to see this thread. Would you kindly post here the relevant bits, if possible?
|
|
Reporter | |
Comment 2•4 years ago
|
||
You are right that this can be achieved with manually created custom views. I opened this bug just in case this was an easy change, which I thought it might be :D
Unfortunately I can't seem to be able to see this thread. Would you kindly post here the relevant bits, if possible?
Sure, here is the full transcript of the message:
This is the table we have for mozilla vpn client telemetry up until now - https://dictionary.telemetry.mozilla.org/apps/mozilla_vpn/app_ids/mozillavpn/tables/mainWe have recently moved the telemetry for android out for better performance. This appears to have ended up in a table called "org.mozilla.firefox.vpn". (https://dictionary.telemetry.mozilla.org/apps/mozilla_vpn_android/app_ids/org_mozilla_firefox_vpn/tables/main)This is confusing to me because
(a) it doesn't name itself similar to the mozillavpn table but with an _android suffix
(b) makes it look like they're the same thing - which would you pick org.mozilla.firefox.vpn or mozillavpn
(c) mozilla vpn doesn't ever use firefox / firefox naming or branding so it's inclusion is confusing (edited)
|
|
||
Comment 3•4 years ago
|
||
(In reply to Beatriz Rizental [:brizental] from comment #2)
You are right that this can be achieved with manually created custom views. I opened this bug just in case this was an easy change, which I thought it might be :D
Heh, you did a good thing. The change is "easy", but the implications of making such a change are not just a few :)
Would you kindly file a jira ticket here (Data Org component) for creating a joined view?
Unfortunately I can't seem to be able to see this thread. Would you kindly post here the relevant bits, if possible?
Sure, here is the full transcript of the message:
This is the table we have for mozilla vpn client telemetry up until now - https://dictionary.telemetry.mozilla.org/apps/mozilla_vpn/app_ids/mozillavpn/tables/mainWe have recently moved the telemetry for android out for better performance. This appears to have ended up in a table called "org.mozilla.firefox.vpn". (https://dictionary.telemetry.mozilla.org/apps/mozilla_vpn_android/app_ids/org_mozilla_firefox_vpn/tables/main)This is confusing to me because
(a) it doesn't name itself similar to the mozillavpn table but with an _android suffix
(b) makes it look like they're the same thing - which would you pick org.mozilla.firefox.vpn or mozillavpn
(c) mozilla vpn doesn't ever use firefox / firefox naming or branding so it's inclusion is confusing (edited)
Got it. I'll note that the previous version of VPN, although written in QT, was running on Android already and that the native Android VPN it's indeed identified as "mozilla firefox VPN" on the Google Play Store (https://play.google.com/store/apps/details?id=org.mozilla.firefox.vpn).
Closing this as WORKSFORME as this is something that should be resolved beyond the SDK.
Description
•