177884 - remove unneeded uses of nsCOMPtr<T>::get from the tree

Status: RESOLVED INCOMPLETE

(Core :: XPCOM, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

We should remove unneeded (mainly due to the fix for bug 65664) uses of
nsCOMPtr<T>::get from the tree.  Their continued presence in the tree makes
people think they're still needed, which makes understanding nsCOMPtr harder.

A way to do this would be to:
 * pull a clean tree
 * rename |get| to |xget| or something like that
 * let the compiler find all the uses of get, and change the correct ones to
xget and remove the ones that are no longer needed.
 * diff the tree to make a patch
 * reverse-apply the patch
 * search replace the patch s/xget/get/
 * reapply the patch
 * make a new (correct) patch by diffing the tree again

Comment 1

[Scott Collins]

collecting under tracking bug # 178174