1778883 - Login to server pop.gmx.net with username [e-mail] failed (with 40 letter password, some extended ascii)

Status: RESOLVED FIXED

(MailNews Core :: Networking: POP, defect)

Description

[lukas.schroeder]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0

Steps to reproduce:

After using Thunderbird 91.9.1 I upgraded to 102.0.1 today, which caused one of my email adresses to start failing to login.
I also have another @gmx.de mail in my profile which works as intended. I also confirmed my password was correct by logging into my accoung via the web browser.

Changing my password resolved the issue.
My old password had 40 letters. Maybe that was already the problem, or maybe it was one of the letters, which were all randomly selected from the extended ascii table

Actual results:

I receive the message "Login to server pop.gmx.net with username [e-mail] failed."

Expected results:

Login should work

Comment 1

[Thomas D. (:thomas8)]

2022-07-11_1317_mass-mark-TB102found

Comment 2

[Ping Chen [:rnons] (away)]

Attachment: Bug 1778883 - Support non-ascii password for USER/PASS auth in Pop3Client. r=mkmelin

Introduce getPlainToken() in MailAuthenticator.jsm.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e89396a4e123
Support non-ascii password for USER/PASS auth in Pop3Client. r=mkmelin

Comment 4

[Ping Chen [:rnons] (away)]

Comment on attachment 9285997 [details]
Bug 1778883 - Support non-ascii password for USER/PASS auth in Pop3Client. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): bug 1707548
User impact if declined: Non-ascii password doesn't work for USER/PASS auth in pop3
Testing completed (on c-c, etc.): beta
Risk to taking this patch (and alternatives if risky): low

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9285997 [details]
Bug 1778883 - Support non-ascii password for USER/PASS auth in Pop3Client. r=mkmelin

[Triage Comment]
Approved for esr102

Comment 6

[Rob Lemley [:rjl]]

This either needs some things from bug 1762690 that landed in June after 102 went to beta or an esr102 specific patch.
Yet another example of why bugs should not have patches landing in two different milestones.

Comment 7

[Ping Chen [:rnons] (away)]

Attachment: 1778883-esr102.patch

Rebase to esr102, include two util functions in MailStringUtils.jsm.

Comment 8

[Rob Lemley [:rjl]]

Comment on attachment 9288449 [details] [diff] [review]
1778883-esr102.patch

Review of attachment 9288449 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 102.1.1:
https://hg.mozilla.org/releases/comm-esr102/rev/043a8a60623a