1778910 - Implement the fontVariantCaps attribute for Canvas2D text

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Comment 1

[Jonathan Kew [:jfkthame]]

As for fontKerning, the current Blink implementation (and associated WPT tests) seems wrong to me, in that it treats the keyword value strings as case-insensitive; see bug 1778908 comment 1.

Comment 2

[Ashley Hale [:ahale]]

Triage - since this is a defect, it needs severity, I am uncertain how this feature affects the appearance of text on a canvas2D, so I am marking this S4 as a possibly just cosmetic issue - is there an example in the wild?

Comment 3

[Jonathan Kew [:jfkthame]]

Before we do this, I'm seeking clarification of a spec/interop issue -- see https://github.com/whatwg/html/issues/8103 and https://crbug.com/1343549. Basically, the question is how fontVariantCaps should interact with the font attribute, which may specify the small-caps variant (but not other caps variants).

Comment 4

[Jonathan Kew [:jfkthame]]

Bumping this to S3; it seems like a pretty normal-level feature, where lack of support could result in a site getting lowercase text where it wanted small-caps. Also, the Interop-2023 offscreen-canvas tests include a couple for fontVariantCaps, which we currently fail.

Comment 5

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1778910 - Implement setting/getting the fontVariantCaps attribute on Canvas2D context (note: no rendering support yet). r=#gfx-reviewers,#webidl

Surprisingly, this is sufficient to pass the existing WPT tests for fontVariantCaps.
(They only test setting and reading the attribute, but don't verify that it actually
has any effect on rendering!)

Rendering tests will be added in the next patch, along with hooking up the behavior.

Comment 6

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1778910 - Hook up rendering support for canvas2d fontVariantCaps, and add WPT reftests. r=#gfx-reviewers

The behavior in some of these cases is open to debate, as the spec is quite unclear;
see https://github.com/whatwg/html/issues/8103. What I've implemented here gives the
rendering result as Chrome for these tests, so hopefully we can get this clarified
in the spec as well.

Depends on D182566

Comment 7

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1778910 - Add offscreen-canvas versions of WPT reftests for fontVariantCaps. r=#gfx-reviewers

Test the same features as the canvas-element reftests, for both a main-thread
OffscreenCanvas and in a worker.

Depends on D182567

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d87582a5c11f
Implement setting/getting the fontVariantCaps attribute on Canvas2D context (note: no rendering support yet). r=gfx-reviewers,webidl,lsalzman,saschanaz
https://hg.mozilla.org/integration/autoland/rev/d59f1e7c17c5
Hook up rendering support for canvas2d fontVariantCaps, and add WPT reftests. r=gfx-reviewers,lsalzman
https://hg.mozilla.org/integration/autoland/rev/75478b5852a3
Add offscreen-canvas versions of WPT reftests for fontVariantCaps. r=gfx-reviewers,lsalzman

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/40871 for changes under testing/web-platform/tests

Comment 10

[Atila Butkovits]

Backed out for causing failures at fontVariantCaps

Backout link: https://hg.mozilla.org/integration/autoland/rev/ab08a64452cd0f4fb7efb0e275dec31e0d9fc1ff

Push where failures started: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&searchStr=wr&revision=cf717d6692eb6ff08bb1d0342645c7c6c1dcf8f7&selectedTaskRun=HYGunfz2QJyFQVFRTQJGlg.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=421446106&repo=autoland&lineNumber=20673

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c3b75097bc02
Implement setting/getting the fontVariantCaps attribute on Canvas2D context (note: no rendering support yet). r=gfx-reviewers,webidl,lsalzman,saschanaz
https://hg.mozilla.org/integration/autoland/rev/def0a0be81f9
Hook up rendering support for canvas2d fontVariantCaps, and add WPT reftests. r=gfx-reviewers,lsalzman
https://hg.mozilla.org/integration/autoland/rev/892665cb2eb7
Add offscreen-canvas versions of WPT reftests for fontVariantCaps. r=gfx-reviewers,lsalzman

Comment 13

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/c3b75097bc02
https://hg.mozilla.org/mozilla-central/rev/def0a0be81f9
https://hg.mozilla.org/mozilla-central/rev/892665cb2eb7

Comment 14

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot