1778999 - Remove backward compatible code from httpd.js

Status: RESOLVED FIXED

(Core :: Networking, task, P2)

Description

[Tooru Fujisawa [:arai]]

bug 1667455 exposes Services property on privileged global, and httpd.js doesn't have to import Services.jsm in the patched binary,
but httpd.js is used also by host-utils, and until it gets updated (bug 1778998), httpd.js contains backward compatible code

https://hg.mozilla.org/integration/autoland/rev/911d540fce6f

-const { Services } = ChromeUtils.import("resource://gre/modules/Services.jsm");
+// httpd.js is loaded by Android hostutils that's not up to date.
+// Fallback to Services.jsm if `Services` global variable isn't yet available.
+const Services =
+  globalThis.Services ||
+  ChromeUtils.import("resource://gre/modules/Services.jsm").Services;

once hostutils gets updated, we can remove the Services declaration above.

Comment 1

[edgul]

:arai, will this be handled by author of 1667455 and/or 1778998? Or will necko team be responsible for implementing this change?

Comment 2

[Tooru Fujisawa [:arai]]

I can handle this, but bug 1778998 needs someone else.

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1778999 - Remove backward compatible code for Services.jsm from httpd.js. r?#necko-reviewers!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a45685de846c
Remove backward compatible code for Services.jsm from httpd.js. r=necko-reviewers,valentin

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a45685de846c